Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc

Issue 7057038: dom-ui sync: Eliminate jank when customizing sync settings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: comment tweak Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.h" 5 #include "chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/metrics/histogram.h" 9 #include "base/metrics/histogram.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
(...skipping 1003 matching lines...) Expand 10 before | Expand all | Expand 10 after
1014 PopupMenuForNode(sender, node, event); 1014 PopupMenuForNode(sender, node, event);
1015 } 1015 }
1016 1016
1017 return FALSE; 1017 return FALSE;
1018 } 1018 }
1019 1019
1020 gboolean BookmarkBarGtk::OnSyncErrorButtonPressed(GtkWidget* sender, 1020 gboolean BookmarkBarGtk::OnSyncErrorButtonPressed(GtkWidget* sender,
1021 GdkEventButton* event) { 1021 GdkEventButton* event) {
1022 if (sender == sync_error_button_) { 1022 if (sender == sync_error_button_) {
1023 DCHECK(sync_service_ && !sync_service_->IsManaged()); 1023 DCHECK(sync_service_ && !sync_service_->IsManaged());
1024 sync_service_->ShowErrorUI(); 1024 sync_service_->ShowErrorUI(NULL);
1025 } 1025 }
1026 1026
1027 return FALSE; 1027 return FALSE;
1028 } 1028 }
1029 1029
1030 void BookmarkBarGtk::OnClicked(GtkWidget* sender) { 1030 void BookmarkBarGtk::OnClicked(GtkWidget* sender) {
1031 const BookmarkNode* node = GetNodeForToolButton(sender); 1031 const BookmarkNode* node = GetNodeForToolButton(sender);
1032 DCHECK(node); 1032 DCHECK(node);
1033 DCHECK(node->is_url()); 1033 DCHECK(node->is_url());
1034 DCHECK(page_navigator_); 1034 DCHECK(page_navigator_);
(...skipping 427 matching lines...) Expand 10 before | Expand all | Expand 10 after
1462 1462
1463 // Find the GtkWidget* for the actual target button. 1463 // Find the GtkWidget* for the actual target button.
1464 int shift = dir == GTK_MENU_DIR_PARENT ? -1 : 1; 1464 int shift = dir == GTK_MENU_DIR_PARENT ? -1 : 1;
1465 button_idx = (button_idx + shift + folder_list.size()) % folder_list.size(); 1465 button_idx = (button_idx + shift + folder_list.size()) % folder_list.size();
1466 PopupForButton(folder_list[button_idx]); 1466 PopupForButton(folder_list[button_idx]);
1467 } 1467 }
1468 1468
1469 void BookmarkBarGtk::CloseMenu() { 1469 void BookmarkBarGtk::CloseMenu() {
1470 current_context_menu_->Cancel(); 1470 current_context_menu_->Cancel();
1471 } 1471 }
OLDNEW
« no previous file with comments | « chrome/browser/sync/sync_ui_util.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698