dom-ui sync: Eliminate jank when customizing sync settings.

chrome/browser/sync/profile_sync_service.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_
 #define CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_
 #pragma once
 
 #include <string>
 
@@ skipping 20 matching lines @@
 #include "content/common/notification_observer.h"
 #include "content/common/notification_registrar.h"
 #include "content/common/notification_type.h"
 #include "googleurl/src/gurl.h"
 
 class NotificationDetails;
 class NotificationSource;
 class Profile;
 class ProfileSyncFactory;
 class SigninManager;
+class WebUI;
 
 namespace browser_sync {
 class BackendMigrator;
 class ChangeProcessor;
 class DataTypeManager;
 class JsFrontend;
 class SessionModelAssociator;
 namespace sessions { struct SyncSessionSnapshot; }
 }
 
@@ skipping 181 matching lines @@
   // Displays a dialog for the user to enter GAIA credentials and attempt
   // re-authentication, and returns true if it actually opened the dialog.
   // Returns false if a dialog is already showing, an auth attempt is in
   // progress, the sync system is already authenticated, or some error
   // occurred preventing the action. We make it the duty of ProfileSyncService
   // to open the dialog to easily ensure only one is ever showing.
   virtual bool SetupInProgress() const;
   bool WizardIsVisible() const {
     return wizard_.IsVisible();
   }
-  virtual void ShowLoginDialog();
+
   SyncSetupWizard& get_wizard() { return wizard_; }
 
+  // Shows the login screen of the Sync setup wizard.  |web_ui| is the WebUI
+  // object for a current settings tab, NULL if one doesn't exist or the calling
+  // code doesn't know.
+  virtual void ShowLoginDialog(WebUI* web_ui);
+
   // This method handles clicks on "sync error" UI, showing the appropriate
-  // dialog for the error condition (relogin / enter passphrase).
-  virtual void ShowErrorUI();
+  // dialog for the error condition (relogin / enter passphrase).  |web_ui| is
+  // the WebUI object for a current settings tab, NULL if one doesn't exist or
+  // the calling code doesn't know.
+  virtual void ShowErrorUI(WebUI* web_ui);
 
   // Shows the configure screen of the Sync setup wizard. If |sync_everything|
   // is true, shows the corresponding page in the customize screen; otherwise,
   // displays the page that gives the user the ability to select which data
-  // types to sync.
-  void ShowConfigure(bool sync_everything);
+  // types to sync.  |web_ui| is the WebUI object for a current settings tab,
+  // NULL if one doesn't exist or the calling code doesn't know.
+  void ShowConfigure(WebUI* web_ui, bool sync_everything);
 
   void PromptForExistingPassphrase();
 
   // Pretty-printed strings for a given StatusSummary.
   static std::string BuildSyncStatusSummaryText(
       const browser_sync::SyncBackendHost::StatusSummary& summary);
 
   // Returns true if the SyncBackendHost has told us it's ready to accept
   // changes.
   // [REMARK] - it is safe to call this function only from the ui thread.
@@ skipping 404 matching lines @@
   };
 
   EncryptedTypes encrypted_types_;
 
   scoped_ptr<browser_sync::BackendMigrator> migrator_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileSyncService);
 };
 
 #endif  // CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_