Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3525)

Unified Diff: chrome/browser/ui/views/extensions/extension_view.cc

Issue 7057014: Variety of tweaks to View API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_view.cc
===================================================================
--- chrome/browser/ui/views/extensions/extension_view.cc (revision 86083)
+++ chrome/browser/ui/views/extensions/extension_view.cc (working copy)
@@ -29,7 +29,7 @@
// This view needs to be focusable so it can act as the focused view for the
// focus manager. This is required to have SkipDefaultKeyEventProcessing
// called so the tab key events are forwarded to the renderer.
- SetFocusable(true);
+ set_focusable(true);
}
ExtensionView::~ExtensionView() {
@@ -53,7 +53,7 @@
void ExtensionView::SetIsClipped(bool is_clipped) {
if (is_clipped_ != is_clipped) {
is_clipped_ = is_clipped;
- if (IsVisible())
+ if (visible())
ShowIfCompletelyLoaded();
}
}
@@ -63,7 +63,7 @@
}
void ExtensionView::SetVisible(bool is_visible) {
- if (is_visible != IsVisible()) {
+ if (is_visible != visible()) {
NativeViewHost::SetVisible(is_visible);
// Also tell RenderWidgetHostView the new visibility. Despite its name, it
@@ -115,7 +115,7 @@
}
void ExtensionView::ShowIfCompletelyLoaded() {
- if (IsVisible() || is_clipped_)
+ if (visible() || is_clipped_)
return;
// We wait to show the ExtensionView until it has loaded, and the view has
@@ -146,7 +146,7 @@
void ExtensionView::UpdatePreferredSize(const gfx::Size& new_size) {
// Don't actually do anything with this information until we have been shown.
// Size changes will not be honored by lower layers while we are hidden.
- if (!IsVisible()) {
+ if (!visible()) {
pending_preferred_size_ = new_size;
return;
}
« no previous file with comments | « chrome/browser/ui/views/extensions/extension_installed_bubble.cc ('k') | chrome/browser/ui/views/find_bar_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698