Variety of tweaks to View API.

chrome/browser/ui/views/extensions/extension_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/extensions/extension_view.h"
 
 #include "chrome/browser/extensions/extension_host.h"
 #include "chrome/browser/ui/views/extensions/extension_popup.h"
 #include "content/browser/renderer_host/render_view_host.h"
 #include "content/browser/renderer_host/render_widget_host_view.h"
@@ skipping 11 matching lines @@
     : host_(host),
       browser_(browser),
       initialized_(false),
       container_(NULL),
       is_clipped_(false) {
   host_->set_view(this);
 
   // This view needs to be focusable so it can act as the focused view for the
   // focus manager. This is required to have SkipDefaultKeyEventProcessing
   // called so the tab key events are forwarded to the renderer.
-  SetFocusable(true);
+  set_focusable(true);
 }
 
 ExtensionView::~ExtensionView() {
   if (parent())
     parent()->RemoveChildView(this);
   CleanUp();
 }
 
 const Extension* ExtensionView::extension() const {
   return host_->extension();
 }
 
 RenderViewHost* ExtensionView::render_view_host() const {
   return host_->render_view_host();
 }
 
 void ExtensionView::DidStopLoading() {
   ShowIfCompletelyLoaded();
 }
 
 void ExtensionView::SetIsClipped(bool is_clipped) {
   if (is_clipped_ != is_clipped) {
     is_clipped_ = is_clipped;
-    if (IsVisible())
+    if (visible())
       ShowIfCompletelyLoaded();
   }
 }
 
 gfx::NativeCursor ExtensionView::GetCursor(const views::MouseEvent& event) {
   return NULL;
 }
 
 void ExtensionView::SetVisible(bool is_visible) {
-  if (is_visible != IsVisible()) {
+  if (is_visible != visible()) {
     NativeViewHost::SetVisible(is_visible);
 
     // Also tell RenderWidgetHostView the new visibility. Despite its name, it
     // is not part of the View hierarchy and does not know about the change
     // unless we tell it.
     if (render_view_host()->view()) {
       if (is_visible)
         render_view_host()->view()->Show();
       else
         render_view_host()->view()->Hide();
@@ skipping 31 matching lines @@
   Attach(view_gtk->GetNativeView());
 #else
   NOTIMPLEMENTED();
 #endif
 
   host_->CreateRenderViewSoon(view);
   SetVisible(false);
 }
 
 void ExtensionView::ShowIfCompletelyLoaded() {
-  if (IsVisible() || is_clipped_)
+  if (visible() || is_clipped_)
     return;
 
   // We wait to show the ExtensionView until it has loaded, and the view has
   // actually been created. These can happen in different orders.
   if (host_->did_stop_loading()) {
     SetVisible(true);
     UpdatePreferredSize(pending_preferred_size_);
   }
 }
 
@@ skipping 10 matching lines @@
     render_view_host()->view()->SetBackground(background);
   } else {
     pending_background_ = background;
   }
   ShowIfCompletelyLoaded();
 }
 
 void ExtensionView::UpdatePreferredSize(const gfx::Size& new_size) {
   // Don't actually do anything with this information until we have been shown.
   // Size changes will not be honored by lower layers while we are hidden.
-  if (!IsVisible()) {
+  if (!visible()) {
     pending_preferred_size_ = new_size;
     return;
   }
 
   gfx::Size preferred_size = GetPreferredSize();
   if (new_size != preferred_size)
     SetPreferredSize(new_size);
 }
 
 void ExtensionView::ViewHierarchyChanged(bool is_add,
@@ skipping 38 matching lines @@
     render_view_host()->view()->SetBackground(pending_background_);
     pending_background_.reset();
   }
 
   // Tell the renderer not to draw scroll bars in popups unless the
   // popups are at the maximum allowed size.
   gfx::Size largest_popup_size(ExtensionPopup::kMaxWidth,
                                ExtensionPopup::kMaxHeight);
   host_->DisableScrollbarsForSmallWindows(largest_popup_size);
 }