chrome/browser/ui/views/find_bar_view.cc - Issue 7057014: Variety of tweaks to View API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/find_bar_view.cc

Issue 7057014: Variety of tweaks to View API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/extensions/extension_view.cc ('k') | chrome/browser/ui/views/frame/app_panel_browser_frame_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/find_bar_view.cc

===================================================================

--- chrome/browser/ui/views/find_bar_view.cc (revision 86083)

+++ chrome/browser/ui/views/find_bar_view.cc (working copy)

@@ -76,11 +76,11 @@

close_button_(NULL),

background_(NULL),

background_left_(NULL) {

- SetID(VIEW_ID_FIND_IN_PAGE);

+ set_id(VIEW_ID_FIND_IN_PAGE);

ResourceBundle& rb = ResourceBundle::GetSharedInstance();

find_text_ = new SearchTextfieldView();

- find_text_->SetID(VIEW_ID_FIND_IN_PAGE_TEXT_FIELD);

+ find_text_->set_id(VIEW_ID_FIND_IN_PAGE_TEXT_FIELD);

find_text_->SetFont(rb.GetFont(ResourceBundle::BaseFont));

find_text_->set_default_width_in_chars(kDefaultCharWidth);

find_text_->SetController(this);

@@ -99,7 +99,7 @@

find_previous_button_ = new views::ImageButton(this);

find_previous_button_->set_tag(FIND_PREVIOUS_TAG);

- find_previous_button_->SetFocusable(true);

+ find_previous_button_->set_focusable(true);

find_previous_button_->SetImage(views::CustomButton::BS_NORMAL,

rb.GetBitmapNamed(IDR_FINDINPAGE_PREV));

find_previous_button_->SetImage(views::CustomButton::BS_HOT,

@@ -114,7 +114,7 @@

find_next_button_ = new views::ImageButton(this);

find_next_button_->set_tag(FIND_NEXT_TAG);

- find_next_button_->SetFocusable(true);

+ find_next_button_->set_focusable(true);

find_next_button_->SetImage(views::CustomButton::BS_NORMAL,

rb.GetBitmapNamed(IDR_FINDINPAGE_NEXT));

find_next_button_->SetImage(views::CustomButton::BS_HOT,

@@ -129,7 +129,7 @@

close_button_ = new views::ImageButton(this);

close_button_->set_tag(CLOSE_TAG);

- close_button_->SetFocusable(true);

+ close_button_->set_focusable(true);

close_button_->SetImage(views::CustomButton::BS_NORMAL,

rb.GetBitmapNamed(IDR_CLOSE_BAR));

close_button_->SetImage(views::CustomButton::BS_HOT,