Initial IndexedDBQuotaClient implementation

Initial IndexedDBQuotaClient implementation

* Heavily based off of DatabaseQuotaClient.
* Only responds to one request so far, GetOriginUsage.

BUG=83652
TEST=llvm/Debug/unit_tests --gtest_filter=IndexedDB*

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87076

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87424

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87834

[dgrogan, 2011-05-26 01:37:42]

http://codereview.chromium.org/7053030/diff/7001/content/browser/in_process_w...
File content/browser/in_process_webkit/webkit_context.cc (left):

http://codereview.chromium.org/7053030/diff/7001/content/browser/in_process_w...
content/browser/in_process_webkit/webkit_context.cc:44: delete
indexed_db_context;
I forgot to revisit this after changing indexed_db_context_ from ScopedPtr to
ScopedRefPtr.  Looking at it now.

[michaeln, 2011-05-26 03:48:41]

http://codereview.chromium.org/7053030/diff/7001/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile.cc (right):

http://codereview.chromium.org/7053030/diff/7001/chrome/browser/profiles/prof...
chrome/browser/profiles/profile.cc:688: DCHECK(db_tracker_.get());
DCHECK(webkit_context_.get()) to be consistent

http://codereview.chromium.org/7053030/diff/7001/chrome/browser/profiles/prof...
chrome/browser/profiles/profile.cc:717: BrowserThread::PostTask(
since this PostTask is really part of the appcache init sequence, can you put
the WebKitContext ctor up above to keep the appcache related lines sequential

http://codereview.chromium.org/7053030/diff/7001/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_impl.cc (right):

http://codereview.chromium.org/7053030/diff/7001/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_impl.cc:1322:
BrowserThread::GetMessageLoopProxyForThread(BrowserThread::WEBKIT));
same comment here

http://codereview.chromium.org/7053030/diff/7001/content/browser/in_process_w...
File content/browser/in_process_webkit/indexed_db_context.h (right):

http://codereview.chromium.org/7053030/diff/7001/content/browser/in_process_w...
content/browser/in_process_webkit/indexed_db_context.h:31: class
IndexedDBContext : public base::RefCountedThreadSafe<IndexedDBContext> {
    : public base::RefCountedThreadSafe<IndexedDBContext,
                                        BrowserThread::DeleteOnWebKitThread>


This class has state that looks like it really needs to be deleted on the WebKit
thread.

http://codereview.chromium.org/7053030/diff/7001/content/browser/in_process_w...
File content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc
(right):

http://codereview.chromium.org/7053030/diff/7001/content/browser/in_process_w...
content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc:93:
FilePath file_path_origin_b = indexeddb_dir.Append(file_name_origin_b);
could you use idb_context()->GetIndexedDBFilePath(origin_id) to construct these
paths?

http://codereview.chromium.org/7053030/diff/7001/content/browser/in_process_w...
File content/browser/in_process_webkit/webkit_context.cc (left):

http://codereview.chromium.org/7053030/diff/7001/content/browser/in_process_w...
content/browser/in_process_webkit/webkit_context.cc:44: delete
indexed_db_context;
On 2011/05/26 01:37:42, dgrogan wrote:
> I forgot to revisit this after changing indexed_db_context_ from ScopedPtr to
> ScopedRefPtr.  Looking at it now.

If your switching the IndexDBContext to be refcounted then the explicit call to
delete doesn't make sense anymore. I think you could let the scoped_refptr
automatically call release for u.

[dgrogan, 2011-05-26 05:41:19]

Michael, could you take another look?

http://codereview.chromium.org/7053030/diff/7001/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile.cc (right):

http://codereview.chromium.org/7053030/diff/7001/chrome/browser/profiles/prof...
chrome/browser/profiles/profile.cc:688: DCHECK(db_tracker_.get());
On 2011/05/26 03:48:41, michaeln wrote:
> DCHECK(webkit_context_.get()) to be consistent

Done.

http://codereview.chromium.org/7053030/diff/7001/chrome/browser/profiles/prof...
chrome/browser/profiles/profile.cc:717: BrowserThread::PostTask(
On 2011/05/26 03:48:41, michaeln wrote:
> since this PostTask is really part of the appcache init sequence, can you put
> the WebKitContext ctor up above to keep the appcache related lines sequential

Done.

http://codereview.chromium.org/7053030/diff/7001/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_impl.cc (right):

http://codereview.chromium.org/7053030/diff/7001/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_impl.cc:1322:
BrowserThread::GetMessageLoopProxyForThread(BrowserThread::WEBKIT));
On 2011/05/26 03:48:41, michaeln wrote:
> same comment here

Done.

http://codereview.chromium.org/7053030/diff/7001/content/browser/in_process_w...
File content/browser/in_process_webkit/indexed_db_context.h (right):

http://codereview.chromium.org/7053030/diff/7001/content/browser/in_process_w...
content/browser/in_process_webkit/indexed_db_context.h:31: class
IndexedDBContext : public base::RefCountedThreadSafe<IndexedDBContext> {
On 2011/05/26 03:48:41, michaeln wrote:
>     : public base::RefCountedThreadSafe<IndexedDBContext,
>                                         BrowserThread::DeleteOnWebKitThread>

Thanks for pointing this out, writing my own Traits didn't feel right.

> 
> 
> This class has state that looks like it really needs to be deleted on the
WebKit
> thread.

I'm guessing you're referring to the ClearLocalState stuff?

http://codereview.chromium.org/7053030/diff/7001/content/browser/in_process_w...
File content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc
(right):

http://codereview.chromium.org/7053030/diff/7001/content/browser/in_process_w...
content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc:93:
FilePath file_path_origin_b = indexeddb_dir.Append(file_name_origin_b);
On 2011/05/26 03:48:41, michaeln wrote:
> could you use idb_context()->GetIndexedDBFilePath(origin_id) to construct
these
> paths?

Thanks for pointing that out.  Switched.

[michaeln, 2011-05-26 08:40:35]

This framing looks familiar to me :)

I'm not sure what sequence of CLs you have in mind, if you want to land this,
and then continue, or continue to add functionality in this CL before landing.
Any which way is fine so long as the build is in a good state... just let me
know where you want the first stopping point to be.

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
File content/browser/in_process_webkit/indexed_db_quota_client.cc (right):

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
content/browser/in_process_webkit/indexed_db_quota_client.cc:24:
scoped_refptr<base::MessageLoopProxy> webkit_thread_message_loop)
this could be a raw MessageLoopProxy* (others too), i don't think the
scoped_refptr adds value here, just refcount churn.

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
content/browser/in_process_webkit/indexed_db_quota_client.cc:47: FilePath
filePath = indexed_db_context_->GetIndexedDBFilePath(origin_id);
nit: file_path

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
content/browser/in_process_webkit/indexed_db_quota_client.cc:48: if
(!file_util::AbsolutePath(&filePath)) {
is this call necessary? methods in the context class don't have to do this prior
to operating on the returned filepath

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
content/browser/in_process_webkit/indexed_db_quota_client.cc:52: usage_ = 999;
// Arbitrary number that might be recognizable as an error.
why the odd value?

maybe use a different indicator for an error, actually the completion call
doesn't have a place to say 'error', maybe 0 is the best answer for now

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
File content/browser/in_process_webkit/indexed_db_quota_client.h (right):

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
content/browser/in_process_webkit/indexed_db_quota_client.h:32: virtual void
OnQuotaManagerDestroyed();
OVERRIDE keyword here too

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
content/browser/in_process_webkit/indexed_db_quota_client.h:40:
GetOriginsCallback* callback)  OVERRIDE;
nit: extra space

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
File content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc
(right):

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc:12:
#include "base/utf_string_conversions.h"
still needed?

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc:18:
#include "webkit/database/database_tracker.h"
needed or copy/paste artifact?

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc:41: NULL,
NULL);
indent is off

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc:48: usage_
= 0;
maybe init to -1 to ensure something happened in the case where 0 is expected

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc:88:
FilePath file_path_origin_a =
idb_context()->GetIndexedDBFilePath(DatabaseUtil::GetOriginIdentifier(GURL("http://host/")));
you can use kOriginA here and B below

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc:89:
FilePath file_path_origin_b =
idb_context()->GetIndexedDBFilePath(DatabaseUtil::GetOriginIdentifier(GURL("http://host:8000/")));
nit: line lengths

[michaeln, 2011-05-26 18:12:04]

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
File content/browser/in_process_webkit/indexed_db_context.cc (right):

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
content/browser/in_process_webkit/indexed_db_context.cc:67:
quota_manager_proxy->RegisterClient(
if you have in mind to land just the framing w/o the 'client' being functional,
maybe comment out this line that createss and registers it in the initial
landing

[dgrogan, 2011-05-26 18:28:24]

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
File content/browser/in_process_webkit/indexed_db_context.cc (right):

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
content/browser/in_process_webkit/indexed_db_context.cc:67:
quota_manager_proxy->RegisterClient(
On 2011/05/26 18:12:04, michaeln wrote:
> if you have in mind to land just the framing w/o the 'client' being
functional,
> maybe comment out this line that createss and registers it in the initial
> landing

Yeah, that is what I have in mind; I'll comment out the register line.

This reminds me, what do I in chromium to cause this client to be called?

[michaeln, 2011-05-26 19:23:34]

On 2011/05/26 18:28:24, dgrogan wrote:
>
http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
> File content/browser/in_process_webkit/indexed_db_context.cc (right):
> 
>
http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
> content/browser/in_process_webkit/indexed_db_context.cc:67:
> quota_manager_proxy->RegisterClient(
> On 2011/05/26 18:12:04, michaeln wrote:
> > if you have in mind to land just the framing w/o the 'client' being
> functional,
> > maybe comment out this line that createss and registers it in the initial
> > landing
> 
> Yeah, that is what I have in mind; I'll comment out the register line.
> 
> This reminds me, what do I in chromium to cause this client to be called?

Visit a page that uses an IndexedDB or a WebSQLDB or the FileSystem, the
QuotaManager will query its Clients for origins and usage info.

[michaeln, 2011-05-26 19:26:16]

> Visit a page that uses an IndexedDB or a WebSQLDB or the FileSystem, the
> QuotaManager will query its Clients for origins and usage info.

Oh... i guess not IndexedDB yet (since it doesn't ask the QM for a 'quota' yet).

This pages uses webSQL...
http://www.corp.google.com/~michaeln/chrome/bugs/xxxxxx/quota-tracking.html

[dgrogan, 2011-05-26 20:56:04]

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
File content/browser/in_process_webkit/indexed_db_quota_client.cc (right):

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
content/browser/in_process_webkit/indexed_db_quota_client.cc:24:
scoped_refptr<base::MessageLoopProxy> webkit_thread_message_loop)
On 2011/05/26 08:40:35, michaeln wrote:
> this could be a raw MessageLoopProxy* (others too), i don't think the
> scoped_refptr adds value here, just refcount churn.

Done.

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
content/browser/in_process_webkit/indexed_db_quota_client.cc:47: FilePath
filePath = indexed_db_context_->GetIndexedDBFilePath(origin_id);
On 2011/05/26 08:40:35, michaeln wrote:
> nit: file_path

Done.

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
content/browser/in_process_webkit/indexed_db_quota_client.cc:48: if
(!file_util::AbsolutePath(&filePath)) {
On 2011/05/26 08:40:35, michaeln wrote:
> is this call necessary? methods in the context class don't have to do this
prior
> to operating on the returned filepath

I didn't know if it's necessary, but you're right, it's probably not.

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
content/browser/in_process_webkit/indexed_db_quota_client.cc:52: usage_ = 999;
// Arbitrary number that might be recognizable as an error.
On 2011/05/26 08:40:35, michaeln wrote:
> why the odd value?
> 
> maybe use a different indicator for an error, actually the completion call
> doesn't have a place to say 'error', maybe 0 is the best answer for now

Done.

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
File content/browser/in_process_webkit/indexed_db_quota_client.h (right):

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
content/browser/in_process_webkit/indexed_db_quota_client.h:32: virtual void
OnQuotaManagerDestroyed();
On 2011/05/26 08:40:35, michaeln wrote:
> OVERRIDE keyword here too

Done.

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
content/browser/in_process_webkit/indexed_db_quota_client.h:40:
GetOriginsCallback* callback)  OVERRIDE;
On 2011/05/26 08:40:35, michaeln wrote:
> nit: extra space

Done.

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
File content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc
(right):

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc:12:
#include "base/utf_string_conversions.h"
On 2011/05/26 08:40:35, michaeln wrote:
> still needed?

Nope, deleted.

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc:18:
#include "webkit/database/database_tracker.h"
On 2011/05/26 08:40:35, michaeln wrote:
> needed or copy/paste artifact?

Artifact, apparently; deleted.

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc:41: NULL,
NULL);
On 2011/05/26 08:40:35, michaeln wrote:
> indent is off

Done.

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc:48: usage_
= 0;
On 2011/05/26 08:40:35, michaeln wrote:
> maybe init to -1 to ensure something happened in the case where 0 is expected

Done.

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc:88:
FilePath file_path_origin_a =
idb_context()->GetIndexedDBFilePath(DatabaseUtil::GetOriginIdentifier(GURL("http://host/")));
On 2011/05/26 08:40:35, michaeln wrote:
> you can use kOriginA here and B below

Done.

http://codereview.chromium.org/7053030/diff/13001/content/browser/in_process_...
content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc:89:
FilePath file_path_origin_b =
idb_context()->GetIndexedDBFilePath(DatabaseUtil::GetOriginIdentifier(GURL("http://host:8000/")));
On 2011/05/26 08:40:35, michaeln wrote:
> nit: line lengths

Done.

[michaeln, 2011-05-26 21:57:13]

lgtm, but i think we need to find a 'content/in_process_webkit' owner?

[dgrogan, 2011-05-26 22:22:14]

@darin for content OWNERS review

[commit-bot: I haz the power, 2011-05-27 01:41:46]

Presubmit check for 7053030-10030 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
content/browser/in_process_webkit/webkit_context.h,content/browser/in_process_webkit/indexed_db_context.cc,content/browser/in_process_webkit/webkit_context.cc,content/browser/in_process_webkit/indexed_db_quota_client.h,content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc,content/browser/in_process_webkit/indexed_db_context.h,content/browser/in_process_webkit/webkit_context_unittest.cc,content/browser/in_process_webkit/indexed_db_quota_client.cc

[dgrogan, 2011-05-27 01:46:42]

@jam for content OWNERS review?

[dgrogan, 2011-05-28 01:52:43]

Can this updated version get another look?

An IndexedDBContext object was being leaked in the unit tests because there is
no WEBKIT thread for BrowserThread::DeleteOnWebKitThread to delete it on.

This adds a local version of DeleteOnWebKitThread that falls back to the local
thread if the WEBKIT thread doesn't exist.

This patch was rebased so the interdiffs are misleading.  The only change is in
http://codereview.chromium.org/7053030/diff2/10030:15001/content/browser/in_p...

[michaeln, 2011-05-28 02:14:08]

On 2011/05/28 01:52:43, dgrogan wrote:
> Can this updated version get another look?
> 
> An IndexedDBContext object was being leaked in the unit tests because there is
> no WEBKIT thread for BrowserThread::DeleteOnWebKitThread to delete it on.
> 
> This adds a local version of DeleteOnWebKitThread that falls back to the local
> thread if the WEBKIT thread doesn't exist.
> 
> This patch was rebased so the interdiffs are misleading.  The only change is
in

Did the leak happen as a general problem across many unittests or with a
particular unittest?

[dgrogan, 2011-05-28 02:49:47]

On 2011/05/28 02:14:08, michaeln wrote:
> On 2011/05/28 01:52:43, dgrogan wrote:
> > Can this updated version get another look?
> > 
> > An IndexedDBContext object was being leaked in the unit tests because there
is
> > no WEBKIT thread for BrowserThread::DeleteOnWebKitThread to delete it on.
> > 
> > This adds a local version of DeleteOnWebKitThread that falls back to the
local
> > thread if the WEBKIT thread doesn't exist.
> > 
> > This patch was rebased so the interdiffs are misleading.  The only change is
> in
> 
> Did the leak happen as a general problem across many unittests or with a
> particular unittest?

A lot of them.  I think because an IndexedDBContext object is instantiated
whenever a TestingProfile is instantied, which is frequently.

[jam, 2011-05-28 03:08:51]

http://codereview.chromium.org/7053030/diff/15001/content/browser/in_process_...
File content/browser/in_process_webkit/indexed_db_context.h (right):

http://codereview.chromium.org/7053030/diff/15001/content/browser/in_process_...
content/browser/in_process_webkit/indexed_db_context.h:36: DeleteOnWebKitThread>
{
if you want to handle the leak in unittests, then create a fake
BrowserThread::WebKit like this 

http://codesearch.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/chrome/browse...

and call
MessageLoop::current()->RunAllPending();
in the destructor.

[dgrogan, 2011-05-31 23:26:07]

Michael, John,

Could you take another look?

Thanks.

http://codereview.chromium.org/7053030/diff/15001/content/browser/in_process_...
File content/browser/in_process_webkit/indexed_db_context.h (right):

http://codereview.chromium.org/7053030/diff/15001/content/browser/in_process_...
content/browser/in_process_webkit/indexed_db_context.h:36: DeleteOnWebKitThread>
{
On 2011/05/28 03:08:51, John Abd-El-Malek wrote:
> if you want to handle the leak in unittests, then create a fake
> BrowserThread::WebKit like this 
> 
>
http://codesearch.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/chrome/browse...
> 
> and call
> MessageLoop::current()->RunAllPending();
> in the destructor.

Thanks.  Done.

[michaeln, 2011-06-01 00:03:30]

LGTM

[jam, 2011-06-01 01:33:31]

lgtm for the test change

[commit-bot: I haz the power, 2011-06-01 02:42:29]

Change committed as 87424

[dgrogan, 2011-06-01 23:18:12]

Michael, John,

One more look?

I missed a crucial part of the example John linked to and the last patch was
reverted.  This patch *actually* fixes the leak.

[michaeln, 2011-06-02 01:35:11]

lgtm - 3rd times the charm

[jam, 2011-06-03 05:36:36]

lgtm

[commit-bot: I haz the power, 2011-06-03 17:56:00]

Presubmit check for 7053030-29001 failed and returned exit status 1.

Running presubmit commit checks ...
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/verification/presubmit_shim.py", line 34, in
<module>
    sys.exit(presubmit_support.Main(None))
  File "/b/depot_tools/presubmit_support.py", line 1235, in Main
    None)
  File "/b/depot_tools/presubmit_support.py", line 1091, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1006, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 128, in CheckChangeOnCommit
  File "<string>", line 45, in _CommonChecks
  File "/b/depot_tools/presubmit_canned_checks.py", line 890, in
PanProjectChecks
    input_api, output_api, source_file_filter=sources))
  File "/b/depot_tools/presubmit_canned_checks.py", line 743, in CheckOwners
    owners_db.email_regexp)
  File "/b/depot_tools/presubmit_canned_checks.py", line 767, in
_RietveldOwnerAndApprovers
    issue_props = input_api.rietveld.get_issue_properties(
AttributeError: 'NoneType' object has no attribute 'get_issue_properties'
Sending crash report ...
  exception: 'NoneType' object has no attribute 'get_issue_prop
  args: ['/mnt/data/b/commit-queue/verification/presubmit_shim.py', '--commit',
'--author', 'dgrogan@chromium.org', '--issue', '7053030', '--patchset', '29001',
'--name', '7053030-29001', '--description', 'Initial IndexedDBQuotaClient
implementation\n\n* Heavily based off of DatabaseQuotaClient.\n* Only responds
to one request so far, GetOriginUsage.\n\nBUG=83652\nTEST=llvm/Debug/unit_tests
--gtest_filter=IndexedDB*\n\nCommitted:
http://src.chromium.org/viewvc/chrome?view=rev&revision=87076\n\nCommitted:
http://src.chromium.org/viewvc/chrome?view=rev&revision=87424',
'chrome/browser/profiles/profile.cc',
'content/browser/in_process_webkit/indexed_db_context.cc',
'content/browser/in_process_webkit/webkit_context.cc',
'content/browser/in_process_webkit/indexed_db_context.h',
'content/browser/in_process_webkit/indexed_db_quota_client.h',
'content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc',
'content/content_browser.gypi',
'content/browser/in_process_webkit/webkit_context.h',
'chrome/chrome_tests.gypi', 'chrome/browser/profiles/profile_impl.cc',
'content/browser/in_process_webkit/webkit_context_unittest.cc',
'chrome/test/testing_profile.cc',
'content/browser/in_process_webkit/indexed_db_quota_client.cc']
  stack:   File "/mnt/data/b/commit-queue/verification/pres
  host: vm105-m4.golo.chromium.org
  version: 2.6.5 (r265:79063, Apr 16 2010, 13:57:41) 
[GCC 4.
  user: chrome-bot
  cwd: /mnt/data/b/commit-queue/workdir/chromium
A stack trace has been sent to the maintainers.

[M-A Ruel, 2011-06-03 18:45:01]

Fixed bug, reenabling commit bit.

[commit-bot: I haz the power, 2011-06-03 19:43:34]

Change committed as 87834

[M-A Ruel, 2011-06-03 20:14:04]

On 2011/06/03 19:43:34, commit-bot wrote:
> Change committed as 87834

Sorry I had a silly bug in the commit queue that marked the new files on this
change as executable. I've fixed it in
http://src.chromium.org/viewvc/chrome?view=rev&revision=87843