Initial IndexedDBQuotaClient implementation

chrome/browser/profiles/profile.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
@@ skipping 543 matching lines @@
 
   virtual SpellCheckHost* GetSpellCheckHost() {
     return profile_->GetSpellCheckHost();
   }
 
   virtual void ReinitializeSpellCheckHost(bool force) {
     profile_->ReinitializeSpellCheckHost(force);
   }
 
   virtual WebKitContext* GetWebKitContext() {
-    if (!webkit_context_.get()) {
-      webkit_context_ = new WebKitContext(
-          IsOffTheRecord(), GetPath(), GetExtensionSpecialStoragePolicy(),
-          false);
-    }
+    CreateQuotaManagerAndClients();
     return webkit_context_.get();
   }
 
   virtual history::TopSites* GetTopSitesWithoutCreating() {
     return NULL;
   }
 
   virtual history::TopSites* GetTopSites() {
     return NULL;
   }
@@ skipping 103 matching lines @@
     // We do not allow prerendering in OTR profiles at this point.
     // TODO(tburkard): Figure out if we want to support this, and how, at some
     // point in the future.
     return NULL;
   }
 
  private:
   void CreateQuotaManagerAndClients() {
     if (quota_manager_.get()) {
       DCHECK(file_system_context_.get());
       DCHECK(db_tracker_.get());

[michaeln, 2011/05/26 03:48:41]

DCHECK(webkit_context_.get()) to be consistent

[dgrogan, 2011/05/26 05:41:19]

Done.

       return;
     }
 
     // All of the clients have to be created and registered with the
     // QuotaManager prior to the QuotaManger being used. So we do them
     // all together here prior to handing out a reference to anything
     // that utlizes the QuotaManager.
     quota_manager_ = new quota::QuotaManager(
         IsOffTheRecord(),
         GetPath(),
         BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO),
         BrowserThread::GetMessageLoopProxyForThread(BrowserThread::DB));
 
     // Each consumer is responsible for registering its QuotaClient during
     // its construction.
     file_system_context_ = CreateFileSystemContext(
         GetPath(), IsOffTheRecord(),
         GetExtensionSpecialStoragePolicy(),
         quota_manager_->proxy());
     db_tracker_ = new webkit_database::DatabaseTracker(
         GetPath(), IsOffTheRecord(), GetExtensionSpecialStoragePolicy(),
         quota_manager_->proxy(),
         BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE));
     appcache_service_ = new ChromeAppCacheService(quota_manager_->proxy());
+    webkit_context_ = new WebKitContext(
+        IsOffTheRecord(), GetPath(), GetExtensionSpecialStoragePolicy(),
+        false, quota_manager_->proxy(),
+        BrowserThread::GetMessageLoopProxyForThread(BrowserThread::WEBKIT));
     BrowserThread::PostTask(

[michaeln, 2011/05/26 03:48:41]

since this PostTask is really part of the appcache init sequence, can you put
the WebKitContext ctor up above to keep the appcache related lines sequential

[dgrogan, 2011/05/26 05:41:19]

Done.

         BrowserThread::IO, FROM_HERE,
         NewRunnableMethod(
             appcache_service_.get(),
             &ChromeAppCacheService::InitializeOnIOThread,
             IsOffTheRecord()
                 ? FilePath() : GetPath().Append(chrome::kAppCacheDirname),
             &GetResourceContext(),
             make_scoped_refptr(GetExtensionSpecialStoragePolicy()),
             false));
   }
@@ skipping 87 matching lines @@
 };
 #endif
 
 Profile* Profile::CreateOffTheRecordProfile() {
 #if defined(OS_CHROMEOS)
   if (Profile::IsGuestSession())
     return new GuestSessionProfile(this);
 #endif
   return new OffTheRecordProfileImpl(this);
 }