Removes RenderViewHostDelegate::GetBrowserWindowID. Instead the places

Removes RenderViewHostDelegate::GetBrowserWindowID. Instead the places
that care send the correct message. This change is motivated by
wanting to remove SessionID from content. At later cl will remove
TabContentsDelegate::RenderViewCreated.

BUG=none
TEST=none
R=jam@chromium.org,mpcomplete@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88376

[sky, 2011-06-08 14:55:44]

TabContentsDelegate::RenderViewCreated is temporary. I'll move it onto a
TabContentsObserver in a later patch.

  -Scott

[jam, 2011-06-08 17:09:30]

lgtm

http://codereview.chromium.org/7046041/diff/2001/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

http://codereview.chromium.org/7046041/diff/2001/chrome/browser/ui/browser.cc...
chrome/browser/ui/browser.cc:3441: // TODO(sky): move this to a
TabContentsObserver hung off TabContentsWrapper,
you can send this now in ExtensionTabHelper which seems like a decent place
since it's an extension message

[sky, 2011-06-08 17:19:43]

http://codereview.chromium.org/7046041/diff/2001/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

http://codereview.chromium.org/7046041/diff/2001/chrome/browser/ui/browser.cc...
chrome/browser/ui/browser.cc:3441: // TODO(sky): move this to a
TabContentsObserver hung off TabContentsWrapper,
On 2011/06/08 17:09:30, John Abd-El-Malek wrote:
> you can send this now in ExtensionTabHelper which seems like a decent place
> since it's an extension message

That will work now because the window id is in the NavigationController, but it
won't be like that in my next patch.

I plan on creating a RestoreTabHelper that contains the session and window ids.
I'll move this code there (as well as 2863).

[jam, 2011-06-08 17:25:14]

On Wed, Jun 8, 2011 at 10:19 AM, <sky@chromium.org> wrote:

>
> http://codereview.chromium.**org/7046041/diff/2001/chrome/**
>
browser/ui/browser.cc<http://codereview.chromium.org/7046041/diff/2001/chrome/browser/ui/browser.cc>
> File chrome/browser/ui/browser.cc (right):
>
> http://codereview.chromium.**org/7046041/diff/2001/chrome/**
>
browser/ui/browser.cc#**newcode3441<http://codereview.chromium.org/7046041/diff/2001/chrome/browser/ui/browser.cc#newcode3441>
> chrome/browser/ui/browser.cc:**3441: // TODO(sky): move this to a
> TabContentsObserver hung off TabContentsWrapper,
> On 2011/06/08 17:09:30, John Abd-El-Malek wrote:
>
>> you can send this now in ExtensionTabHelper which seems like a decent
>>
> place
>
>> since it's an extension message
>>
>
> That will work now because the window id is in the NavigationController,
> but it won't be like that in my next patch.
>
> I plan on creating a RestoreTabHelper that contains the session and
> window ids. I'll move this code there (as well as 2863).


got it, sg

>
>
>
http://codereview.chromium.**org/7046041/<http://codereview.chromium.org/7046...
>

[Matt Perry, 2011-06-08 18:18:42]

OK, this seems reasonable.

http://codereview.chromium.org/7046041/diff/2001/content/browser/tab_contents...
File content/browser/tab_contents/interstitial_page.cc (left):

http://codereview.chromium.org/7046041/diff/2001/content/browser/tab_contents...
content/browser/tab_contents/interstitial_page.cc:722: int
InterstitialPage::GetBrowserWindowID() const {
does the InterstitialPage need to send the UpdateBrowserId message?

[Matt Perry, 2011-06-08 18:19:10]

lgtm

[jam, 2011-06-08 18:30:08]

http://codereview.chromium.org/7046041/diff/2001/content/browser/tab_contents...
File content/browser/tab_contents/interstitial_page.cc (left):

http://codereview.chromium.org/7046041/diff/2001/content/browser/tab_contents...
content/browser/tab_contents/interstitial_page.cc:722: int
InterstitialPage::GetBrowserWindowID() const {
On 2011/06/08 18:18:42, Matt Perry wrote:
> does the InterstitialPage need to send the UpdateBrowserId message?

based on inspection, it didn't seem that this matters?  i.e. this is ultimately
used in the extension code so that script can enumerate all the tabs/background
pages etc, right?  If so, then it seems that interstitial pages should just be
an internal chrome implementation and not visible?

[Matt Perry, 2011-06-08 18:34:00]

On 2011/06/08 18:30:08, John Abd-El-Malek wrote:
>
http://codereview.chromium.org/7046041/diff/2001/content/browser/tab_contents...
> File content/browser/tab_contents/interstitial_page.cc (left):
> 
>
http://codereview.chromium.org/7046041/diff/2001/content/browser/tab_contents...
> content/browser/tab_contents/interstitial_page.cc:722: int
> InterstitialPage::GetBrowserWindowID() const {
> On 2011/06/08 18:18:42, Matt Perry wrote:
> > does the InterstitialPage need to send the UpdateBrowserId message?
> 
> based on inspection, it didn't seem that this matters?  i.e. this is
ultimately
> used in the extension code so that script can enumerate all the
tabs/background
> pages etc, right?  If so, then it seems that interstitial pages should just be
> an internal chrome implementation and not visible?

Unless an interstitial page can host an extension URL. I'd assume that's not
possible, though.

[jam, 2011-06-08 18:35:14]

On Wed, Jun 8, 2011 at 11:34 AM, <mpcomplete@chromium.org> wrote:

> On 2011/06/08 18:30:08, John Abd-El-Malek wrote:
>
> http://codereview.chromium.**org/7046041/diff/2001/content/**
>
browser/tab_contents/**interstitial_page.cc<http://codereview.chromium.org/7046041/diff/2001/content/browser/tab_contents/interstitial_page.cc>
>
>> File content/browser/tab_contents/**interstitial_page.cc (left):
>>
>
>
> http://codereview.chromium.**org/7046041/diff/2001/content/**
>
browser/tab_contents/**interstitial_page.cc#**oldcode722<http://codereview.chromium.org/7046041/diff/2001/content/browser/tab_contents/interstitial_page.cc#oldcode722>
>
>> content/browser/tab_contents/**interstitial_page.cc:722: int
>> InterstitialPage::**GetBrowserWindowID() const {
>> On 2011/06/08 18:18:42, Matt Perry wrote:
>> > does the InterstitialPage need to send the UpdateBrowserId message?
>>
>
>  based on inspection, it didn't seem that this matters?  i.e. this is
>>
> ultimately
>
>> used in the extension code so that script can enumerate all the
>>
> tabs/background
>
>> pages etc, right?  If so, then it seems that interstitial pages should
>> just be
>> an internal chrome implementation and not visible?
>>
>
> Unless an interstitial page can host an extension URL. I'd assume that's
> not
> possible, though.


AFAIK that's correct.  If extensions can mess with security interstitials,
that'd be a problem.


>
>
>
http://codereview.chromium.**org/7046041/<http://codereview.chromium.org/7046...
>