Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1698)

Unified Diff: chrome/browser/ui/browser.cc

Issue 7046041: Removes RenderViewHostDelegate::GetBrowserWindowID. Instead the places (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix interstitialpage Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index a86afce9005afc41e24958a2d856d5ec2cdbbe3f..74d7ea21af87607912a60ec88454cd4f7aa767c4 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -2859,6 +2859,7 @@ void Browser::TabInsertedAt(TabContentsWrapper* contents,
// Extension code in the renderer holds the ID of the window that hosts it.
// Notify it that the window ID changed.
+ // TODO(sky): move this to a better place.
contents->render_view_host()->Send(new ExtensionMsg_UpdateBrowserWindowId(
contents->render_view_host()->routing_id(),
contents->controller().window_id().id()));
@@ -3436,6 +3437,14 @@ content::JavaScriptDialogCreator* Browser::GetJavaScriptDialogCreator() {
return GetJavaScriptDialogCreatorInstance();
}
+void Browser::RenderViewCreated(TabContents* source, RenderViewHost* host) {
+ // TODO(sky): move this to a TabContentsObserver hung off TabContentsWrapper,
jam 2011/06/08 17:09:30 you can send this now in ExtensionTabHelper which
sky 2011/06/08 17:19:43 That will work now because the window id is in the
+ // then nuke this method.
+ host->Send(new ExtensionMsg_UpdateBrowserWindowId(
+ host->routing_id(),
+ source->controller().window_id().id()));
+}
+
///////////////////////////////////////////////////////////////////////////////
// Browser, TabContentsWrapperDelegate implementation:

Powered by Google App Engine
This is Rietveld 408576698