Removes RenderViewHostDelegate::GetBrowserWindowID. Instead the places

chrome/browser/ui/browser.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser.h"
 
 #if defined(OS_WIN)
 #include <shellapi.h>
 #include <windows.h>
 #endif  // OS_WIN
@@ skipping 2841 matching lines @@
 // Browser, TabStripModelObserver implementation:
 
 void Browser::TabInsertedAt(TabContentsWrapper* contents,
                             int index,
                             bool foreground) {
   SetAsDelegate(contents, this);
   contents->controller().SetWindowID(session_id());
 
   // Extension code in the renderer holds the ID of the window that hosts it.
   // Notify it that the window ID changed.
+  // TODO(sky): move this to a better place.
   contents->render_view_host()->Send(new ExtensionMsg_UpdateBrowserWindowId(
       contents->render_view_host()->routing_id(),
       contents->controller().window_id().id()));
 
   SyncHistoryWithTabs(index);
 
   // Make sure the loading state is updated correctly, otherwise the throbber
   // won't start if the page is loading.
   LoadingStateChanged(contents->tab_contents());
 
@@ skipping 557 matching lines @@
       GetSelectedTabContentsWrapper()->bookmark_tab_helper()->
       ShouldShowBookmarkBar()) {
     window()->ShelfVisibilityChanged();
   }
 }
 
 content::JavaScriptDialogCreator* Browser::GetJavaScriptDialogCreator() {
   return GetJavaScriptDialogCreatorInstance();
 }
 
+void Browser::RenderViewCreated(TabContents* source, RenderViewHost* host) {
+  // TODO(sky): move this to a TabContentsObserver hung off TabContentsWrapper,

[jam, 2011/06/08 17:09:30]

you can send this now in ExtensionTabHelper which seems like a decent place
since it's an extension message

[sky, 2011/06/08 17:19:43]

That will work now because the window id is in the NavigationController, but it
won't be like that in my next patch.

I plan on creating a RestoreTabHelper that contains the session and window ids.
I'll move this code there (as well as 2863).

+  // then nuke this method.
+  host->Send(new ExtensionMsg_UpdateBrowserWindowId(
+                 host->routing_id(),
+                 source->controller().window_id().id()));
+}
+
 ///////////////////////////////////////////////////////////////////////////////
 // Browser, TabContentsWrapperDelegate implementation:
 
 void Browser::OnDidGetApplicationInfo(TabContentsWrapper* source,
                                       int32 page_id) {
   if (GetSelectedTabContentsWrapper() != source)
     return;
 
   NavigationEntry* entry = source->controller().GetLastCommittedEntry();
   if (!entry || (entry->page_id() != page_id))
@@ skipping 1246 matching lines @@
   TabContents* current_tab = GetSelectedTabContents();
   if (current_tab) {
     content_restrictions = current_tab->content_restrictions();
     NavigationEntry* active_entry = current_tab->controller().GetActiveEntry();
     // See comment in UpdateCommandsForTabState about why we call url().
     if (!SavePackage::IsSavableURL(active_entry ? active_entry->url() : GURL()))
       content_restrictions |= CONTENT_RESTRICTION_SAVE;
   }
   return content_restrictions;
 }