Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7015051: Re-land: (Closed)

Created:
9 years, 7 months ago by Ben Goodger (Google)
Modified:
9 years, 6 months ago
Reviewers:
CC:
chromium-reviews, Avi (use Gerrit), nkostylev+cc_chromium.org, rharrison, tburkard+watch_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, jam, cbentzel+watch_chromium.org, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., davemoore+watch_chromium.org
Visibility:
Public.

Description

Re-land: Split the hierarchy. Now with AutocompletePopup implementing SupportsWeakPtr as before. This fixes the Windows XP crashes in browser_tests. BUG=72040 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85298

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2502 lines, -2178 lines) Patch
M chrome/browser/chromeos/frame/browser_frame_view_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/frame/browser_view.cc View 5 chunks +5 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/frame/bubble_frame_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/frame/bubble_window.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/frame/bubble_window.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/frame/dom_browser_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/frame/panel_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/background_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/helper.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/screen_locker.cc View 5 chunks +12 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/user_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_controller_gtk.cc View 3 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/native_dialog_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/notifications/balloon_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/notifications/notification_panel.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/panels/panel_scroller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/external_tab_container_win.cc View 6 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/first_run/try_chrome_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_list_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M chrome/browser/ui/gtk/constrained_window_gtk.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/constrained_window_gtk.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/input_window_dialog_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browser_frame_view.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.h View 3 chunks +2 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc View 2 chunks +31 lines, -4 lines 0 comments Download
D chrome/browser/ui/views/autocomplete/autocomplete_popup_gtk.h View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/ui/views/autocomplete/autocomplete_popup_gtk.cc View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/browser/ui/views/autocomplete/autocomplete_popup_win.h View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/ui/views/autocomplete/autocomplete_popup_win.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/browser_bubble.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/browser_bubble.cc View 4 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/browser_bubble_gtk.cc View 4 chunks +18 lines, -26 lines 0 comments Download
M chrome/browser/ui/views/browser_bubble_win.cc View 3 chunks +13 lines, -20 lines 0 comments Download
M chrome/browser/ui/views/bubble/border_widget_win.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/bubble/bubble.cc View 12 chunks +25 lines, -17 lines 0 comments Download
M chrome/browser/ui/views/constrained_html_delegate_gtk.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_views.h View 4 chunks +13 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_views.cc View 4 chunks +15 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/dom_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/download/download_started_animation_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/dropdown_bar_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_popup.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/find_bar_host_interactive_uitest.cc View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_host_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/first_run_bubble.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/first_run_search_engine_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/app_panel_browser_frame_view.cc View 10 chunks +15 lines, -17 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame.h View 4 chunks +13 lines, -24 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame.cc View 3 chunks +94 lines, -20 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_gtk.h View 1 chunk +2 lines, -21 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_gtk.cc View 3 chunks +20 lines, -59 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_win.h View 3 chunks +5 lines, -21 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_win.cc View 10 chunks +26 lines, -102 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 21 chunks +33 lines, -40 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view_layout.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/contents_container.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 15 chunks +18 lines, -22 lines 0 comments Download
M chrome/browser/ui/views/frame/native_browser_frame.h View 1 chunk +7 lines, -18 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 29 chunks +37 lines, -46 lines 0 comments Download
M chrome/browser/ui/views/fullscreen_exit_bubble.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/generic_info_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/handle_web_keyboard_event_gtk.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/html_dialog_view.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/hung_renderer_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/importer/import_progress_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/js_modal_dialog_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/native_constrained_window_win.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/notifications/balloon_view.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/profile_tag_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/status_bubble_views.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_view_delegate.h View 2 chunks +10 lines, -3 lines 0 comments Download
A chrome/browser/ui/views/tab_contents/native_tab_contents_view_gtk.h View 1 chunk +259 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/tab_contents/native_tab_contents_view_gtk.cc View 1 chunk +846 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_view_win.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_view_win.cc View 8 chunks +10 lines, -25 lines 0 comments Download
D chrome/browser/ui/views/tab_contents/tab_contents_view_gtk.h View 1 chunk +0 lines, -143 lines 0 comments Download
D chrome/browser/ui/views/tab_contents/tab_contents_view_gtk.cc View 1 chunk +0 lines, -488 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_view_views.h View 6 chunks +18 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc View 15 chunks +55 lines, -33 lines 0 comments Download
M chrome/browser/ui/views/tabs/base_tab_strip.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/dragged_tab_controller.cc View 3 chunks +5 lines, -13 lines 0 comments Download
M chrome/browser/ui/views/tabs/dragged_tab_view.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/tabs/native_view_photobooth_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/task_manager_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/theme_install_bubble_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 7 chunks +8 lines, -14 lines 0 comments Download
M chrome/test/interactive_ui/view_event_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M views/accessibility/native_view_accessibility_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/combobox/native_combobox_views_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/menu/menu_host.h View 3 chunks +8 lines, -3 lines 0 comments Download
M views/controls/menu/menu_host.cc View 4 chunks +16 lines, -8 lines 0 comments Download
M views/controls/menu/menu_host_gtk.h View 2 chunks +1 line, -3 lines 0 comments Download
M views/controls/menu/menu_host_gtk.cc View 3 chunks +2 lines, -11 lines 0 comments Download
M views/controls/menu/menu_host_win.h View 1 chunk +1 line, -3 lines 0 comments Download
M views/controls/menu/menu_host_win.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M views/controls/menu/native_menu_host_delegate.h View 2 chunks +2 lines, -4 lines 0 comments Download
M views/controls/native/native_view_host_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/tabbed_pane/native_tabbed_pane_gtk.h View 1 chunk +2 lines, -2 lines 0 comments Download
M views/controls/tabbed_pane/native_tabbed_pane_gtk.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M views/controls/tabbed_pane/native_tabbed_pane_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/tabbed_pane/tabbed_pane_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/table/table_view_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/textfield/native_textfield_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/textfield/native_textfield_views_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/examples/widget_example.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M views/focus/accelerator_handler_gtk_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M views/focus/focus_manager_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/focus/focus_manager_unittest.cc View 9 chunks +18 lines, -28 lines 0 comments Download
M views/focus/view_storage.h View 1 chunk +1 line, -1 line 0 comments Download
M views/focus/view_storage.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/view.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/view_unittest.cc View 42 chunks +81 lines, -137 lines 0 comments Download
M views/widget/drop_target_gtk.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M views/widget/native_widget.h View 4 chunks +26 lines, -0 lines 0 comments Download
M views/widget/native_widget_delegate.h View 1 chunk +4 lines, -0 lines 0 comments Download
M views/widget/native_widget_test_utils_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M views/widget/native_widget_test_utils_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M views/widget/tooltip_manager_gtk.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M views/widget/widget.h View 12 chunks +59 lines, -33 lines 0 comments Download
M views/widget/widget.cc View 8 chunks +48 lines, -11 lines 0 comments Download
M views/widget/widget_gtk.h View 8 chunks +25 lines, -34 lines 0 comments Download
M views/widget/widget_gtk.cc View 27 chunks +139 lines, -84 lines 0 comments Download
M views/widget/widget_win.h View 7 chunks +13 lines, -29 lines 0 comments Download
M views/widget/widget_win.cc View 24 chunks +105 lines, -87 lines 0 comments Download
M views/widget/widget_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/window/custom_frame_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/window/dialog_client_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/window/native_frame_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
M views/window/native_frame_view.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M views/window/native_window.h View 2 chunks +5 lines, -2 lines 0 comments Download
M views/window/native_window_delegate.h View 2 chunks +10 lines, -0 lines 0 comments Download
M views/window/window.h View 8 chunks +6 lines, -26 lines 0 comments Download
M views/window/window.cc View 7 chunks +20 lines, -43 lines 0 comments Download
M views/window/window_gtk.h View 3 chunks +4 lines, -6 lines 0 comments Download
M views/window/window_gtk.cc View 10 chunks +24 lines, -45 lines 0 comments Download
M views/window/window_win.h View 4 chunks +6 lines, -6 lines 0 comments Download
M views/window/window_win.cc View 10 chunks +42 lines, -51 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698