Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3803)

Unified Diff: chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

Issue 7015051: Re-land: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_list_win.cc ('k') | chrome/browser/ui/gtk/constrained_window_gtk.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
===================================================================
--- chrome/browser/ui/find_bar/find_bar_host_browsertest.cc (revision 85284)
+++ chrome/browser/ui/find_bar/find_bar_host_browsertest.cc (working copy)
@@ -839,11 +839,8 @@
// For some reason we can't use AddSelectedTabWithURL here on ChromeOS. It
// could be some delicate assumption about the tab starting off unselected or
// something relating to user gesture.
- browser::NavigateParams params(browser(), url, PageTransition::TYPED);
- params.disposition = NEW_BACKGROUND_TAB;
- params.tabstrip_add_types = TabStripModel::ADD_NONE;
- browser::Navigate(&params);
- browser()->ActivateTabAt(1, false);
+ browser()->AddBlankTab(true);
+ ui_test_utils::NavigateToURL(browser(), url);
TabContentsWrapper* tab2 = browser()->GetSelectedTabContentsWrapper();
EXPECT_NE(tab1, tab2);
@@ -963,11 +960,8 @@
FindBarController::kKeepSelection);
// Now create a second tab and load the same page.
- browser::NavigateParams params(browser(), url, PageTransition::TYPED);
- params.disposition = NEW_BACKGROUND_TAB;
- params.tabstrip_add_types = TabStripModel::ADD_NONE;
- browser::Navigate(&params);
- browser()->ActivateTabAt(1, false);
+ browser()->AddBlankTab(true);
+ ui_test_utils::NavigateToURL(browser(), url);
TabContentsWrapper* tab2 = browser()->GetSelectedTabContentsWrapper();
EXPECT_NE(tab1, tab2);
« no previous file with comments | « chrome/browser/ui/browser_list_win.cc ('k') | chrome/browser/ui/gtk/constrained_window_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698