Added DeleteOriginData to QuotaClient

Added DeleteOriginData to QuotaClient

BUG=61676
TEST=SandboxQuotaClientTest.DeleteOriginTest

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85588

[Dai Mikurube (NOT FULLTIME), 2011-05-11 09:14:57]

Just some nit comments.

http://codereview.chromium.org/7003021/diff/1008/webkit/fileapi/file_system_c...
File webkit/fileapi/file_system_context.cc (right):

http://codereview.chromium.org/7003021/diff/1008/webkit/fileapi/file_system_c...
webkit/fileapi/file_system_context.cc:91: file_util::Delete(path_for_origin,
true /* recursive */);
Is the .usage file updated?  (Updating may not be required since the next
usage/quota request for QM results in generating .usage...)

http://codereview.chromium.org/7003021/diff/1008/webkit/fileapi/file_system_c...
File webkit/fileapi/file_system_context.h (right):

http://codereview.chromium.org/7003021/diff/1008/webkit/fileapi/file_system_c...
webkit/fileapi/file_system_context.h:11: #include
"webkit/fileapi/file_system_types.h"
Please sort header files in alphabetical order.

[tzik (google), 2011-05-11 09:32:56]

Thanks.

http://codereview.chromium.org/7003021/diff/1008/webkit/fileapi/file_system_c...
File webkit/fileapi/file_system_context.h (right):

http://codereview.chromium.org/7003021/diff/1008/webkit/fileapi/file_system_c...
webkit/fileapi/file_system_context.h:11: #include
"webkit/fileapi/file_system_types.h"
On 2011/05/11 09:14:57, Dai Mikurube wrote:
> Please sort header files in alphabetical order.

Done.

[kinuko, 2011-05-11 09:38:14]

http://codereview.chromium.org/7003021/diff/1008/webkit/fileapi/file_system_c...
File webkit/fileapi/file_system_context.cc (right):

http://codereview.chromium.org/7003021/diff/1008/webkit/fileapi/file_system_c...
webkit/fileapi/file_system_context.cc:91: file_util::Delete(path_for_origin,
true /* recursive */);
Sorry I hadn't read this review comment (and wasn't aware that we also need a
new method with a 'type' parameter), yes in any case we're deleting the entire
directory including the .usage file and qm will take care of it.

http://codereview.chromium.org/7003021/diff/1008/webkit/fileapi/sandbox_quota...
File webkit/fileapi/sandbox_quota_client.cc (right):

http://codereview.chromium.org/7003021/diff/1008/webkit/fileapi/sandbox_quota...
webkit/fileapi/sandbox_quota_client.cc:311:
->DeleteDataForOriginAndTypeOnFileThread(origin_, type_);
what if we fail to do this?

http://codereview.chromium.org/7003021/diff/1008/webkit/fileapi/sandbox_quota...
webkit/fileapi/sandbox_quota_client.cc:328: FileSystemType fs_type =
QuotaStorageTypeToFileSystemType(type);
DCHECK(fs_type != kFileSystemTypeUnknown)

[kinuko, 2011-05-11 09:45:56]

http://codereview.chromium.org/7003021/diff/1008/webkit/fileapi/file_system_c...
File webkit/fileapi/file_system_context.cc (right):

http://codereview.chromium.org/7003021/diff/1008/webkit/fileapi/file_system_c...
webkit/fileapi/file_system_context.cc:86: DCHECK(path_manager_.get());
This doesn't seem to be necessary.  (Ditto in the method above, probably those
are remnants of the legacy code...)
Could you remove them together while you're there?

[tzik (google), 2011-05-11 11:32:25]

http://codereview.chromium.org/7003021/diff/1008/webkit/fileapi/file_system_c...
File webkit/fileapi/file_system_context.cc (right):

http://codereview.chromium.org/7003021/diff/1008/webkit/fileapi/file_system_c...
webkit/fileapi/file_system_context.cc:86: DCHECK(path_manager_.get());
On 2011/05/11 09:45:56, kinuko wrote:
> This doesn't seem to be necessary.  (Ditto in the method above, probably those
> are remnants of the legacy code...)
> Could you remove them together while you're there?

Done.

http://codereview.chromium.org/7003021/diff/1008/webkit/fileapi/sandbox_quota...
File webkit/fileapi/sandbox_quota_client.cc (right):

http://codereview.chromium.org/7003021/diff/1008/webkit/fileapi/sandbox_quota...
webkit/fileapi/sandbox_quota_client.cc:328: FileSystemType fs_type =
QuotaStorageTypeToFileSystemType(type);
On 2011/05/11 09:38:15, kinuko wrote:
> DCHECK(fs_type != kFileSystemTypeUnknown)

Done.

[kinuko, 2011-05-11 12:18:49]

a few cosmetic comments

http://codereview.chromium.org/7003021/diff/6011/webkit/fileapi/sandbox_quota...
File webkit/fileapi/sandbox_quota_client.cc (right):

http://codereview.chromium.org/7003021/diff/6011/webkit/fileapi/sandbox_quota...
webkit/fileapi/sandbox_quota_client.cc:303: origin_(origin), type_(type),
nit: type_() in the next line

http://codereview.chromium.org/7003021/diff/6011/webkit/fileapi/sandbox_quota...
webkit/fileapi/sandbox_quota_client.cc:312:
->DeleteDataForOriginAndTypeOnFileThread(origin_, type_))
style nit: weird indentation

not sure what would be best in this case, maybe

if (file_system_context_->
        DeleteDataForOriginAndTypeOnFileThread(...))

?  (in general we don't start a line with an operator)

[kinuko, 2011-05-12 05:54:15]

http://codereview.chromium.org/7003021/diff/6011/webkit/fileapi/sandbox_quota...
File webkit/fileapi/sandbox_quota_client.cc (right):

http://codereview.chromium.org/7003021/diff/6011/webkit/fileapi/sandbox_quota...
webkit/fileapi/sandbox_quota_client.cc:342: new DeleteOriginTask(this,
file_message_loop_,
Sorry, please forget what I said about ScopedRunnableMethodFactory... we seem to
need a task here.

[kinuko, 2011-05-12 08:59:22]

(adding michael as it adds a mock impl to DB quota client)

http://codereview.chromium.org/7003021/diff/9001/webkit/fileapi/file_system_c...
File webkit/fileapi/file_system_context.cc (right):

http://codereview.chromium.org/7003021/diff/9001/webkit/fileapi/file_system_c...
webkit/fileapi/file_system_context.cc:81: 
nit: extra empty line

http://codereview.chromium.org/7003021/diff/9001/webkit/fileapi/sandbox_quota...
File webkit/fileapi/sandbox_quota_client.cc (right):

http://codereview.chromium.org/7003021/diff/9001/webkit/fileapi/sandbox_quota...
webkit/fileapi/sandbox_quota_client.cc:321: callback_->Run(status_);
hmm do we need to fire the callback in abort case?

http://codereview.chromium.org/7003021/diff/9001/webkit/fileapi/sandbox_quota...
File webkit/fileapi/sandbox_quota_client.h (right):

http://codereview.chromium.org/7003021/diff/9001/webkit/fileapi/sandbox_quota...
webkit/fileapi/sandbox_quota_client.h:48: 
nit: please remove this empty line

http://codereview.chromium.org/7003021/diff/9001/webkit/quota/quota_client.h
File webkit/quota/quota_client.h (right):

http://codereview.chromium.org/7003021/diff/9001/webkit/quota/quota_client.h#...
webkit/quota/quota_client.h:61: 
Can we add a comment on which thread we'll be calling this method. (db thread?)

[kinuko, 2011-05-12 10:46:54]

lgtm

[tzik (google), 2011-05-12 10:47:06]

http://codereview.chromium.org/7003021/diff/6011/webkit/fileapi/sandbox_quota...
File webkit/fileapi/sandbox_quota_client.cc (right):

http://codereview.chromium.org/7003021/diff/6011/webkit/fileapi/sandbox_quota...
webkit/fileapi/sandbox_quota_client.cc:303: origin_(origin), type_(type),
On 2011/05/11 12:18:49, kinuko wrote:
> nit: type_() in the next line

Done.

http://codereview.chromium.org/7003021/diff/6011/webkit/fileapi/sandbox_quota...
webkit/fileapi/sandbox_quota_client.cc:312:
->DeleteDataForOriginAndTypeOnFileThread(origin_, type_))
On 2011/05/11 12:18:49, kinuko wrote:
> style nit: weird indentation
> 
> not sure what would be best in this case, maybe
> 
> if (file_system_context_->
>         DeleteDataForOriginAndTypeOnFileThread(...))
> 
> ?  (in general we don't start a line with an operator)

Done.

http://codereview.chromium.org/7003021/diff/9001/webkit/fileapi/file_system_c...
File webkit/fileapi/file_system_context.cc (right):

http://codereview.chromium.org/7003021/diff/9001/webkit/fileapi/file_system_c...
webkit/fileapi/file_system_context.cc:81: 
On 2011/05/12 08:59:22, kinuko wrote:
> nit: extra empty line

Done.

http://codereview.chromium.org/7003021/diff/9001/webkit/fileapi/sandbox_quota...
File webkit/fileapi/sandbox_quota_client.cc (right):

http://codereview.chromium.org/7003021/diff/9001/webkit/fileapi/sandbox_quota...
webkit/fileapi/sandbox_quota_client.cc:321: callback_->Run(status_);
On 2011/05/12 08:59:22, kinuko wrote:
> hmm do we need to fire the callback in abort case?

Done.

http://codereview.chromium.org/7003021/diff/9001/webkit/fileapi/sandbox_quota...
File webkit/fileapi/sandbox_quota_client.h (right):

http://codereview.chromium.org/7003021/diff/9001/webkit/fileapi/sandbox_quota...
webkit/fileapi/sandbox_quota_client.h:48: 
On 2011/05/12 08:59:22, kinuko wrote:
> nit: please remove this empty line

Done.

[kinuko, 2011-05-12 10:52:13]

Sorry, please add tests...

On 2011/05/12 10:47:06, tzik (google) wrote:
>
http://codereview.chromium.org/7003021/diff/6011/webkit/fileapi/sandbox_quota...
> File webkit/fileapi/sandbox_quota_client.cc (right):
> 
>
http://codereview.chromium.org/7003021/diff/6011/webkit/fileapi/sandbox_quota...
> webkit/fileapi/sandbox_quota_client.cc:303: origin_(origin), type_(type),
> On 2011/05/11 12:18:49, kinuko wrote:
> > nit: type_() in the next line
> 
> Done.
> 
>
http://codereview.chromium.org/7003021/diff/6011/webkit/fileapi/sandbox_quota...
> webkit/fileapi/sandbox_quota_client.cc:312:
> ->DeleteDataForOriginAndTypeOnFileThread(origin_, type_))
> On 2011/05/11 12:18:49, kinuko wrote:
> > style nit: weird indentation
> > 
> > not sure what would be best in this case, maybe
> > 
> > if (file_system_context_->
> >         DeleteDataForOriginAndTypeOnFileThread(...))
> > 
> > ?  (in general we don't start a line with an operator)
> 
> Done.
> 
>
http://codereview.chromium.org/7003021/diff/9001/webkit/fileapi/file_system_c...
> File webkit/fileapi/file_system_context.cc (right):
> 
>
http://codereview.chromium.org/7003021/diff/9001/webkit/fileapi/file_system_c...
> webkit/fileapi/file_system_context.cc:81: 
> On 2011/05/12 08:59:22, kinuko wrote:
> > nit: extra empty line
> 
> Done.
> 
>
http://codereview.chromium.org/7003021/diff/9001/webkit/fileapi/sandbox_quota...
> File webkit/fileapi/sandbox_quota_client.cc (right):
> 
>
http://codereview.chromium.org/7003021/diff/9001/webkit/fileapi/sandbox_quota...
> webkit/fileapi/sandbox_quota_client.cc:321: callback_->Run(status_);
> On 2011/05/12 08:59:22, kinuko wrote:
> > hmm do we need to fire the callback in abort case?
> 
> Done.
> 
>
http://codereview.chromium.org/7003021/diff/9001/webkit/fileapi/sandbox_quota...
> File webkit/fileapi/sandbox_quota_client.h (right):
> 
>
http://codereview.chromium.org/7003021/diff/9001/webkit/fileapi/sandbox_quota...
> webkit/fileapi/sandbox_quota_client.h:48: 
> On 2011/05/12 08:59:22, kinuko wrote:
> > nit: please remove this empty line
> 
> Done.

[michaeln, 2011-05-13 01:04:24]

> (adding michael as it adds a mock impl to DB quota client)

ok... i'll fill it in afterwards

http://codereview.chromium.org/7003021/diff/8003/webkit/database/database_quo...
File webkit/database/database_quota_client.cc (right):

http://codereview.chromium.org/7003021/diff/8003/webkit/database/database_quo...
webkit/database/database_quota_client.cc:220: DeletionCallback* callback) {
Please move this method up in the .cc file so it's defined in the same are as
it's declared.

Also, do you want to invoke and delete the callback in the stub impl...

   callback-Run(kSuccess)
   delete callback;

http://codereview.chromium.org/7003021/diff/8003/webkit/quota/quota_manager.h
File webkit/quota/quota_manager.h (right):

http://codereview.chromium.org/7003021/diff/8003/webkit/quota/quota_manager.h...
webkit/quota/quota_manager.h:153: static void Destruct(const QuotaManager*
manager) {
looks like a stray edit

[tzik (google), 2011-05-13 06:10:36]

http://codereview.chromium.org/7003021/diff/8003/webkit/database/database_quo...
File webkit/database/database_quota_client.cc (right):

http://codereview.chromium.org/7003021/diff/8003/webkit/database/database_quo...
webkit/database/database_quota_client.cc:220: DeletionCallback* callback) {
On 2011/05/13 01:04:24, michaeln wrote:
> Please move this method up in the .cc file so it's defined in the same are as
> it's declared.
> 
> Also, do you want to invoke and delete the callback in the stub impl...
> 
>    callback-Run(kSuccess)
>    delete callback;

Done.

http://codereview.chromium.org/7003021/diff/8003/webkit/quota/quota_manager.h
File webkit/quota/quota_manager.h (right):

http://codereview.chromium.org/7003021/diff/8003/webkit/quota/quota_manager.h...
webkit/quota/quota_manager.h:153: static void Destruct(const QuotaManager*
manager) {
On 2011/05/13 01:04:24, michaeln wrote:
> looks like a stray edit

Done.

[kinuko, 2011-05-13 07:26:00]

http://codereview.chromium.org/7003021/diff/11023/webkit/fileapi/sandbox_quot...
File webkit/fileapi/sandbox_quota_client.cc (right):

http://codereview.chromium.org/7003021/diff/11023/webkit/fileapi/sandbox_quot...
webkit/fileapi/sandbox_quota_client.cc:313:
DeleteDataForOriginAndTypeOnFileThread(origin_, type_))
style-nit: weird indentation

file_system_context_->
    DeleteDataFor...

http://codereview.chromium.org/7003021/diff/11023/webkit/fileapi/sandbox_quot...
File webkit/fileapi/sandbox_quota_client_unittest.cc (right):

http://codereview.chromium.org/7003021/diff/11023/webkit/fileapi/sandbox_quot...
webkit/fileapi/sandbox_quota_client_unittest.cc:492:
GetOriginUsage(quota_client.get(), "http://foo.com/",  kPersistent));
style-nit: over 80 chars

http://codereview.chromium.org/7003021/diff/11023/webkit/fileapi/sandbox_quot...
webkit/fileapi/sandbox_quota_client_unittest.cc:496:
GetOriginUsage(quota_client.get(), "https://bar.com/", kPersistent));
ditto

[michaeln, 2011-05-13 07:28:02]

lgtm (just some nits) if it lgt<kinuko>

if the delete vs other callback semantics don't currently match, i can take
another when they do match if you like

http://codereview.chromium.org/7003021/diff/11023/webkit/fileapi/sandbox_quot...
File webkit/fileapi/sandbox_quota_client.cc (right):

http://codereview.chromium.org/7003021/diff/11023/webkit/fileapi/sandbox_quot...
webkit/fileapi/sandbox_quota_client.cc:292: class
SandboxQuotaClient::DeleteOriginTask
probably better to move this class definition up in the .cc file to be nearer to
the other inner task classes

http://codereview.chromium.org/7003021/diff/11023/webkit/fileapi/sandbox_quot...
webkit/fileapi/sandbox_quota_client.cc:320: callback_->Run(status_);
i'm not sure if the callbacks are expected to be run upon destruction if the
'client' or not. the other methods indirectly invoke the callbacks via a helper.
please make sure these callbacks have the same behavior upon destruction while
inflight.

http://codereview.chromium.org/7003021/diff/11023/webkit/fileapi/sandbox_quot...
webkit/fileapi/sandbox_quota_client.cc:330: void
SandboxQuotaClient::DeleteOriginData(const GURL& origin,
please move this method up in the .cc file to match its order in the .h file

http://codereview.chromium.org/7003021/diff/11023/webkit/fileapi/sandbox_quot...
File webkit/fileapi/sandbox_quota_client_unittest.cc (right):

http://codereview.chromium.org/7003021/diff/11023/webkit/fileapi/sandbox_quot...
webkit/fileapi/sandbox_quota_client_unittest.cc:191: quota::QuotaStatusCode
status(){ return quota_status_; }
maybe delete_status_ and delete_status()

http://codereview.chromium.org/7003021/diff/11023/webkit/fileapi/sandbox_quot...
webkit/fileapi/sandbox_quota_client_unittest.cc:468:
CreateFiles(kFiles,ARRAYSIZE_UNSAFE(kFiles));
missing space before,ARRAY (why does lint not run?)

http://codereview.chromium.org/7003021/diff/11023/webkit/fileapi/sandbox_quot...
webkit/fileapi/sandbox_quota_client_unittest.cc:492:
GetOriginUsage(quota_client.get(), "http://foo.com/",  kPersistent));
line length

http://codereview.chromium.org/7003021/diff/11023/webkit/fileapi/sandbox_quot...
webkit/fileapi/sandbox_quota_client_unittest.cc:496:
GetOriginUsage(quota_client.get(), "https://bar.com/", kPersistent));
line length

[tzik (google), 2011-05-13 14:22:24]

http://codereview.chromium.org/7003021/diff/11023/webkit/fileapi/sandbox_quot...
File webkit/fileapi/sandbox_quota_client.cc (right):

http://codereview.chromium.org/7003021/diff/11023/webkit/fileapi/sandbox_quot...
webkit/fileapi/sandbox_quota_client.cc:292: class
SandboxQuotaClient::DeleteOriginTask
On 2011/05/13 07:28:02, michaeln wrote:
> probably better to move this class definition up in the .cc file to be nearer
to
> the other inner task classes

Done.

http://codereview.chromium.org/7003021/diff/11023/webkit/fileapi/sandbox_quot...
webkit/fileapi/sandbox_quota_client.cc:313:
DeleteDataForOriginAndTypeOnFileThread(origin_, type_))
On 2011/05/13 07:26:00, kinuko wrote:
> style-nit: weird indentation
> 
> file_system_context_->
>     DeleteDataFor...

Done.

http://codereview.chromium.org/7003021/diff/11023/webkit/fileapi/sandbox_quot...
webkit/fileapi/sandbox_quota_client.cc:320: callback_->Run(status_);
On 2011/05/13 07:28:02, michaeln wrote:
> i'm not sure if the callbacks are expected to be run upon destruction if the
> 'client' or not. the other methods indirectly invoke the callbacks via a
helper.
> please make sure these callbacks have the same behavior upon destruction while
> inflight.

We believe, that's no problem. It's same to others (like usage_tracker).

http://codereview.chromium.org/7003021/diff/11023/webkit/fileapi/sandbox_quot...
webkit/fileapi/sandbox_quota_client.cc:330: void
SandboxQuotaClient::DeleteOriginData(const GURL& origin,
On 2011/05/13 07:28:02, michaeln wrote:
> please move this method up in the .cc file to match its order in the .h file

Done.

http://codereview.chromium.org/7003021/diff/11023/webkit/fileapi/sandbox_quot...
File webkit/fileapi/sandbox_quota_client_unittest.cc (right):

http://codereview.chromium.org/7003021/diff/11023/webkit/fileapi/sandbox_quot...
webkit/fileapi/sandbox_quota_client_unittest.cc:191: quota::QuotaStatusCode
status(){ return quota_status_; }
On 2011/05/13 07:28:02, michaeln wrote:
> maybe delete_status_ and delete_status()

Done.

http://codereview.chromium.org/7003021/diff/11023/webkit/fileapi/sandbox_quot...
webkit/fileapi/sandbox_quota_client_unittest.cc:468:
CreateFiles(kFiles,ARRAYSIZE_UNSAFE(kFiles));
On 2011/05/13 07:28:02, michaeln wrote:
> missing space before,ARRAY (why does lint not run?)

Done.
Thanks, I'll try it.

http://codereview.chromium.org/7003021/diff/11023/webkit/fileapi/sandbox_quot...
webkit/fileapi/sandbox_quota_client_unittest.cc:492:
GetOriginUsage(quota_client.get(), "http://foo.com/",  kPersistent));
On 2011/05/13 07:28:02, michaeln wrote:
> line length

Done.

http://codereview.chromium.org/7003021/diff/11023/webkit/fileapi/sandbox_quot...
webkit/fileapi/sandbox_quota_client_unittest.cc:496:
GetOriginUsage(quota_client.get(), "https://bar.com/", kPersistent));
On 2011/05/13 07:28:02, michaeln wrote:
> line length

Done.

http://codereview.chromium.org/7003021/diff/11023/webkit/quota/mock_storage_c...
File webkit/quota/mock_storage_client.cc (right):

http://codereview.chromium.org/7003021/diff/11023/webkit/quota/mock_storage_c...
webkit/quota/mock_storage_client.cc:161: DeletionCallback* callback_ptr) {
Something to be done here

[kinuko, 2011-05-16 06:18:53]

http://codereview.chromium.org/7003021/diff/20001/webkit/database/database_qu...
File webkit/database/database_quota_client.cc (right):

http://codereview.chromium.org/7003021/diff/20001/webkit/database/database_qu...
webkit/database/database_quota_client.cc:5: #include <vector>
style-nit: This must be after "webkit/database/database_quota_client.h" I think.
 (Is this warned by lint?)

http://codereview.chromium.org/7003021/diff/20001/webkit/fileapi/file_system_...
File webkit/fileapi/file_system_context.cc (right):

http://codereview.chromium.org/7003021/diff/20001/webkit/fileapi/file_system_...
webkit/fileapi/file_system_context.cc:88: return
file_util::Delete(path_for_origin, true /* recursive */);
Can you add TODO here to report the amount of deleted data to QM too?  (My
another patch will cover it)

http://codereview.chromium.org/7003021/diff/20001/webkit/fileapi/sandbox_quot...
File webkit/fileapi/sandbox_quota_client_unittest.cc (right):

http://codereview.chromium.org/7003021/diff/20001/webkit/fileapi/sandbox_quot...
webkit/fileapi/sandbox_quota_client_unittest.cc:509: kTemporary));
This looks good and no need to change this, but I felt this might be too much to
test DeleteOrigin... (like: tests for foo/bar look really similar to me)?

http://codereview.chromium.org/7003021/diff/20001/webkit/quota/mock_storage_c...
File webkit/quota/mock_storage_client.cc (right):

http://codereview.chromium.org/7003021/diff/20001/webkit/quota/mock_storage_c...
webkit/quota/mock_storage_client.cc:170:
origin_data_.erase(make_pair(origin_url, type));
Here can we call NotifyStorageModified with -origin_size?

http://codereview.chromium.org/7003021/diff/20001/webkit/quota/quota_manager_...
File webkit/quota/quota_manager_unittest.cc (right):

http://codereview.chromium.org/7003021/diff/20001/webkit/quota/quota_manager_...
webkit/quota/quota_manager_unittest.cc:667: }
Can we add one more test with delete origin?  (The GetXxxUsage should report the
updated usage)

[tzik (google), 2011-05-16 07:47:01]

http://codereview.chromium.org/7003021/diff/20001/webkit/database/database_qu...
File webkit/database/database_quota_client.cc (right):

http://codereview.chromium.org/7003021/diff/20001/webkit/database/database_qu...
webkit/database/database_quota_client.cc:5: #include <vector>
On 2011/05/16 06:18:53, kinuko wrote:
> style-nit: This must be after "webkit/database/database_quota_client.h" I
think.
>  (Is this warned by lint?)

Done.

http://codereview.chromium.org/7003021/diff/20001/webkit/fileapi/file_system_...
File webkit/fileapi/file_system_context.cc (right):

http://codereview.chromium.org/7003021/diff/20001/webkit/fileapi/file_system_...
webkit/fileapi/file_system_context.cc:88: return
file_util::Delete(path_for_origin, true /* recursive */);
On 2011/05/16 06:18:53, kinuko wrote:
> Can you add TODO here to report the amount of deleted data to QM too?  (My
> another patch will cover it)

Done.

http://codereview.chromium.org/7003021/diff/20001/webkit/quota/mock_storage_c...
File webkit/quota/mock_storage_client.cc (right):

http://codereview.chromium.org/7003021/diff/20001/webkit/quota/mock_storage_c...
webkit/quota/mock_storage_client.cc:170:
origin_data_.erase(make_pair(origin_url, type));
On 2011/05/16 06:18:53, kinuko wrote:
> Here can we call NotifyStorageModified with -origin_size?

Done.

http://codereview.chromium.org/7003021/diff/20001/webkit/quota/quota_manager_...
File webkit/quota/quota_manager_unittest.cc (right):

http://codereview.chromium.org/7003021/diff/20001/webkit/quota/quota_manager_...
webkit/quota/quota_manager_unittest.cc:667: }
On 2011/05/16 06:18:53, kinuko wrote:
> Can we add one more test with delete origin?  (The GetXxxUsage should report
the
> updated usage)

Done.

[kinuko, 2011-05-16 07:50:18]

lgtm thanks!