Added DeleteOriginData to QuotaClient

webkit/fileapi/sandbox_quota_client.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/fileapi/sandbox_quota_client.h"
 
 #include <algorithm>
 #include <set>
 
 #include "base/file_path.h"
@@ skipping 271 matching lines @@
   DCHECK(pending_origins_for_type_callbacks_.HasCallbacks(type));
   pending_origins_for_type_callbacks_.Run(type, origins);
 }
 
 void SandboxQuotaClient::DidGetOriginsForHost(
     const TypeAndHostOrOrigin& type_and_host, const std::set<GURL>& origins) {
   DCHECK(pending_origins_for_host_callbacks_.HasCallbacks(type_and_host));
   pending_origins_for_host_callbacks_.Run(type_and_host, origins);
 }
 
+class SandboxQuotaClient::DeleteOriginTask
+    : public QuotaThreadTask {
+ public:
+  DeleteOriginTask(
+      SandboxQuotaClient* quota_client,
+      scoped_refptr<MessageLoopProxy> file_message_loop,
+      const GURL& origin,
+      FileSystemType type,
+      DeletionCallback* callback)
+      : QuotaThreadTask(quota_client, file_message_loop),
+        file_system_context_(quota_client->file_system_context_),
+        origin_(origin), type_(type),

[kinuko, 2011/05/11 12:18:49]

nit: type_() in the next line

[tzik (google), 2011/05/12 10:47:06]

Done.

+        status_(quota::kQuotaStatusUnknown),
+        callback_(callback) {
+  }
+
+  virtual ~DeleteOriginTask() {}
+
+  virtual void RunOnTargetThread() OVERRIDE {
+    if (file_system_context_
+        ->DeleteDataForOriginAndTypeOnFileThread(origin_, type_))

[kinuko, 2011/05/11 12:18:49]

style nit: weird indentation

not sure what would be best in this case, maybe

if (file_system_context_->
        DeleteDataForOriginAndTypeOnFileThread(...))

?  (in general we don't start a line with an operator)

[tzik (google), 2011/05/12 10:47:06]

Done.

+      status_ = quota::kQuotaStatusOk;
+    else
+      status_ = quota::kQuotaErrorInvalidModification;
+  }
+
+  virtual void Aborted() OVERRIDE {
+    status_ = quota::kQuotaErrorAbort;
+    callback_->Run(status_);
+    delete callback_;
+  }
+
+  virtual void Completed() OVERRIDE {
+    callback_->Run(status_);
+    delete callback_;
+  }
+ private:
+  FileSystemContext* file_system_context_;
+  GURL origin_;
+  FileSystemType type_;
+  quota::QuotaStatusCode status_;
+  DeletionCallback* callback_;
+};
+
+void SandboxQuotaClient::DeleteOriginData(const GURL& origin,
+                                          StorageType type,
+                                          DeletionCallback* callback) {
+  FileSystemType fs_type = QuotaStorageTypeToFileSystemType(type);
+  DCHECK(fs_type != kFileSystemTypeUnknown);
+  scoped_ptr<DeleteOriginTask> task(
+      new DeleteOriginTask(this, file_message_loop_,

[kinuko, 2011/05/12 05:54:15]

Sorry, please forget what I said about ScopedRunnableMethodFactory... we seem to
need a task here.

+                           origin, fs_type, callback));
+  task->Start();
+}
+
 }  // namespace fileapi