Added DeleteOriginData to QuotaClient

webkit/fileapi/file_system_context.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/fileapi/file_system_context.h"
 
 #include "base/file_util.h"
 #include "base/message_loop_proxy.h"
 #include "googleurl/src/gurl.h"
 #include "webkit/fileapi/file_system_path_manager.h"
@@ skipping 62 matching lines @@
 void FileSystemContext::DeleteDataForOriginOnFileThread(
     const GURL& origin_url) {
   DCHECK(path_manager_.get());
   DCHECK(file_message_loop_->BelongsToCurrentThread());
 
   FilePath path_for_origin =
       sandbox_provider()->GetBaseDirectoryForOrigin(origin_url);
   file_util::Delete(path_for_origin, true /* recursive */);
 }
 
+
+void FileSystemContext::DeleteDataForOriginAndTypeOnFileThread(
+    const GURL& origin_url, FileSystemType type) {
+  DCHECK(path_manager_.get());

[kinuko, 2011/05/11 09:45:56]

This doesn't seem to be necessary.  (Ditto in the method above, probably those
are remnants of the legacy code...)
Could you remove them together while you're there?

[tzik (google), 2011/05/11 11:32:25]

Done.

+  DCHECK(file_message_loop_->BelongsToCurrentThread());
+
+  FilePath path_for_origin =
+      sandbox_provider()->GetBaseDirectoryForOriginAndType(origin_url, type);
+  file_util::Delete(path_for_origin, true /* recursive */);

[Dai Mikurube (NOT FULLTIME), 2011/05/11 09:14:57]

Is the .usage file updated?  (Updating may not be required since the next
usage/quota request for QM results in generating .usage...)

[kinuko, 2011/05/11 09:38:15]

Sorry I hadn't read this review comment (and wasn't aware that we also need a
new method with a 'type' parameter), yes in any case we're deleting the entire
directory including the .usage file and qm will take care of it.

+}
+
 void FileSystemContext::DeleteOnCorrectThread() const {
   if (!io_message_loop_->BelongsToCurrentThread()) {
     io_message_loop_->DeleteSoon(FROM_HERE, this);
     return;
   }
   delete this;
 }
 
 SandboxMountPointProvider* FileSystemContext::sandbox_provider() const {
   return path_manager_->sandbox_provider();
 }
 
 }  // namespace fileapi