Issue 6993054: MIPS: Fixed FPU rounding checks and related errors in the Simulator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6993054: MIPS: Fixed FPU rounding checks and related errors in the Simulator. (Closed)

Created:
9 years, 6 months ago by Paul Lind

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse, Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

MIPS: Fixed FPU rounding checks and related errors in the Simulator. Removed some unnecessary shifts when reading FCSR error flags. Fixed some FCSR-related bugs. Fixed some un-related style issues. With this commit, mips build is still broken. Two more commits to come. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8173

Patch Set 1 #

Total comments: 2

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+83 lines, -94 lines)			Patch
M	src/mips/code-stubs-mips.cc	View	6 chunks	+8 lines, -8 lines	0 comments	Download
M	src/mips/constants-mips.h	View	1 chunk	+20 lines, -7 lines	2 comments	Download
M	src/mips/macro-assembler-mips.cc	View	7 chunks	+8 lines, -1 line	0 comments	Download
M	src/mips/simulator-mips.cc	View	3 chunks	+34 lines, -14 lines	0 comments	Download
M	src/mips/stub-cache-mips.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	test/cctest/test-assembler-mips.cc	View	2 chunks	+12 lines, -61 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

9 years, 6 months ago (2011-06-06 08:39:02 UTC) #2

LGTM, I'll fix the nits and land.

http://codereview.chromium.org/6993054/diff/1/src/mips/constants-mips.h
File src/mips/constants-mips.h (right):

http://codereview.chromium.org/6993054/diff/1/src/mips/constants-mips.h#newco...
src/mips/constants-mips.h:109: kFCSRUnderflowFlagMask |
Four-space indent for these.

http://codereview.chromium.org/6993054/diff/1/src/mips/constants-mips.h#newco...
src/mips/constants-mips.h:115: kFCSRInexactFlagMask;
Four-space indent.

Expand Messages | Collapse Messages