Issue 6993023: Fix a bug in Lithium environment iteration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6993023: Fix a bug in Lithium environment iteration. (Closed)

Created:
9 years, 6 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 6 months ago

Reviewers:
fschneider, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix a bug in Lithium environment iteration. The Advance() function of the class responsible for iterating environment uses didn't always advance as far as it could (relying on the HasNext predicate to finish advancing). This is brittle. The HasNext predicate also didn't advance as far as it could when it was at the end of an environment level. This is a bug. R=jkummerow@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8181

Patch Set 1 #

Patch Set 2 : Rename HasNext => !Done, Next => Current. #

Patch Set 3 : Added x64 and ARM files. #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+151 lines, -88 lines)			Patch
M	src/arm/lithium-arm.cc	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/lithium.h	View	1	2 chunks	+28 lines, -32 lines	0 comments	Download
M	src/lithium-allocator.h	View	1	3 chunks	+8 lines, -8 lines	0 comments	Download
M	src/lithium-allocator.cc	View	1	5 chunks	+9 lines, -9 lines	0 comments	Download
M	src/lithium-allocator-inl.h	View	1	4 chunks	+29 lines, -27 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download
A	test/mjsunit/regress/regress-1423.js	View		1 chunk	+65 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

+fschneider Florian, can you take a quick look at this.

9 years, 6 months ago (2011-06-06 11:06:48 UTC) #3

LGTM

(sorry for the delay)

Expand Messages | Collapse Messages