Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 6993023: Fix a bug in Lithium environment iteration. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Added x64 and ARM files. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/lithium.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 71
72 #ifdef DEBUG 72 #ifdef DEBUG
73 void LInstruction::VerifyCall() { 73 void LInstruction::VerifyCall() {
74 // Call instructions can use only fixed registers as temporaries and 74 // Call instructions can use only fixed registers as temporaries and
75 // outputs because all registers are blocked by the calling convention. 75 // outputs because all registers are blocked by the calling convention.
76 // Inputs operands must use a fixed register or use-at-start policy or 76 // Inputs operands must use a fixed register or use-at-start policy or
77 // a non-register policy. 77 // a non-register policy.
78 ASSERT(Output() == NULL || 78 ASSERT(Output() == NULL ||
79 LUnallocated::cast(Output())->HasFixedPolicy() || 79 LUnallocated::cast(Output())->HasFixedPolicy() ||
80 !LUnallocated::cast(Output())->HasRegisterPolicy()); 80 !LUnallocated::cast(Output())->HasRegisterPolicy());
81 for (UseIterator it(this); it.HasNext(); it.Advance()) { 81 for (UseIterator it(this); !it.Done(); it.Advance()) {
82 LUnallocated* operand = LUnallocated::cast(it.Next()); 82 LUnallocated* operand = LUnallocated::cast(it.Current());
83 ASSERT(operand->HasFixedPolicy() || 83 ASSERT(operand->HasFixedPolicy() ||
84 operand->IsUsedAtStart()); 84 operand->IsUsedAtStart());
85 } 85 }
86 for (TempIterator it(this); it.HasNext(); it.Advance()) { 86 for (TempIterator it(this); !it.Done(); it.Advance()) {
87 LUnallocated* operand = LUnallocated::cast(it.Next()); 87 LUnallocated* operand = LUnallocated::cast(it.Current());
88 ASSERT(operand->HasFixedPolicy() ||!operand->HasRegisterPolicy()); 88 ASSERT(operand->HasFixedPolicy() ||!operand->HasRegisterPolicy());
89 } 89 }
90 } 90 }
91 #endif 91 #endif
92 92
93 93
94 void LInstruction::PrintTo(StringStream* stream) { 94 void LInstruction::PrintTo(StringStream* stream) {
95 stream->Add("%s ", this->Mnemonic()); 95 stream->Add("%s ", this->Mnemonic());
96 96
97 PrintOutputOperandTo(stream); 97 PrintOutputOperandTo(stream);
(...skipping 2193 matching lines...) Expand 10 before | Expand all | Expand 10 after
2291 LOperand* key = UseOrConstantAtStart(instr->key()); 2291 LOperand* key = UseOrConstantAtStart(instr->key());
2292 LOperand* object = UseOrConstantAtStart(instr->object()); 2292 LOperand* object = UseOrConstantAtStart(instr->object());
2293 LIn* result = new LIn(key, object); 2293 LIn* result = new LIn(key, object);
2294 return MarkAsCall(DefineFixed(result, eax), instr); 2294 return MarkAsCall(DefineFixed(result, eax), instr);
2295 } 2295 }
2296 2296
2297 2297
2298 } } // namespace v8::internal 2298 } } // namespace v8::internal
2299 2299
2300 #endif // V8_TARGET_ARCH_IA32 2300 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/lithium.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698