Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 6993023: Fix a bug in Lithium environment iteration. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Added x64 and ARM files. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 61
62 #ifdef DEBUG 62 #ifdef DEBUG
63 void LInstruction::VerifyCall() { 63 void LInstruction::VerifyCall() {
64 // Call instructions can use only fixed registers as temporaries and 64 // Call instructions can use only fixed registers as temporaries and
65 // outputs because all registers are blocked by the calling convention. 65 // outputs because all registers are blocked by the calling convention.
66 // Inputs operands must use a fixed register or use-at-start policy or 66 // Inputs operands must use a fixed register or use-at-start policy or
67 // a non-register policy. 67 // a non-register policy.
68 ASSERT(Output() == NULL || 68 ASSERT(Output() == NULL ||
69 LUnallocated::cast(Output())->HasFixedPolicy() || 69 LUnallocated::cast(Output())->HasFixedPolicy() ||
70 !LUnallocated::cast(Output())->HasRegisterPolicy()); 70 !LUnallocated::cast(Output())->HasRegisterPolicy());
71 for (UseIterator it(this); it.HasNext(); it.Advance()) { 71 for (UseIterator it(this); !it.Done(); it.Advance()) {
72 LUnallocated* operand = LUnallocated::cast(it.Next()); 72 LUnallocated* operand = LUnallocated::cast(it.Current());
73 ASSERT(operand->HasFixedPolicy() || 73 ASSERT(operand->HasFixedPolicy() ||
74 operand->IsUsedAtStart()); 74 operand->IsUsedAtStart());
75 } 75 }
76 for (TempIterator it(this); it.HasNext(); it.Advance()) { 76 for (TempIterator it(this); !it.Done(); it.Advance()) {
77 LUnallocated* operand = LUnallocated::cast(it.Next()); 77 LUnallocated* operand = LUnallocated::cast(it.Current());
78 ASSERT(operand->HasFixedPolicy() ||!operand->HasRegisterPolicy()); 78 ASSERT(operand->HasFixedPolicy() ||!operand->HasRegisterPolicy());
79 } 79 }
80 } 80 }
81 #endif 81 #endif
82 82
83 83
84 void LOsrEntry::MarkSpilledDoubleRegister(int allocation_index, 84 void LOsrEntry::MarkSpilledDoubleRegister(int allocation_index,
85 LOperand* spill_operand) { 85 LOperand* spill_operand) {
86 ASSERT(spill_operand->IsDoubleStackSlot()); 86 ASSERT(spill_operand->IsDoubleStackSlot());
87 ASSERT(double_register_spills_[allocation_index] == NULL); 87 ASSERT(double_register_spills_[allocation_index] == NULL);
(...skipping 2144 matching lines...) Expand 10 before | Expand all | Expand 10 after
2232 2232
2233 LInstruction* LChunkBuilder::DoIn(HIn* instr) { 2233 LInstruction* LChunkBuilder::DoIn(HIn* instr) {
2234 LOperand* key = UseRegisterAtStart(instr->key()); 2234 LOperand* key = UseRegisterAtStart(instr->key());
2235 LOperand* object = UseRegisterAtStart(instr->object()); 2235 LOperand* object = UseRegisterAtStart(instr->object());
2236 LIn* result = new LIn(key, object); 2236 LIn* result = new LIn(key, object);
2237 return MarkAsCall(DefineFixed(result, r0), instr); 2237 return MarkAsCall(DefineFixed(result, r0), instr);
2238 } 2238 }
2239 2239
2240 2240
2241 } } // namespace v8::internal 2241 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698