Issue 6992015: Fix minor issues in ChromeDriver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6992015: Fix minor issues in ChromeDriver. (Closed)

Created:
9 years, 7 months ago by kkania

Modified:
9 years, 7 months ago

Reviewers:
Huyen

CC:
chromium-reviews, kkania, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix minor issues in ChromeDriver: -return a user-friendly error if alerts or advanced user interactions are not supported -change custom switches capability from dictionary to list of switches -fix bug where custom Chrome binary was not being used if custom switches were not provided -do not use DictionaryValue path expansion for capabilities -only print stacktraces on linux -remove 'chrome-dir' argument for chromedriver BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86393

Patch Set 1 #

Patch Set 2 : ... #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+216 lines, -111 lines)			Patch
M	chrome/test/webdriver/automation.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/test/webdriver/automation.cc	View	1	9 chunks	+92 lines, -11 lines	0 comments	Download
M	chrome/test/webdriver/chromedriver_tests.py	View	1	4 chunks	+56 lines, -33 lines	0 comments	Download
M	chrome/test/webdriver/commands/create_session.cc	View	1	1 chunk	+47 lines, -34 lines	0 comments	Download
M	chrome/test/webdriver/commands/session_with_id.cc	View		1 chunk	+8 lines, -3 lines	0 comments	Download
M	chrome/test/webdriver/server.cc	View		3 chunks	+0 lines, -18 lines	0 comments	Download
M	chrome/test/webdriver/session_manager.h	View		2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/test/webdriver/session_manager.cc	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	chrome/test/webdriver/webdriver_error.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages