Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1504)

Unified Diff: chrome/test/webdriver/webdriver_error.cc

Issue 6992015: Fix minor issues in ChromeDriver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ... Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/webdriver/session_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/webdriver/webdriver_error.cc
diff --git a/chrome/test/webdriver/webdriver_error.cc b/chrome/test/webdriver/webdriver_error.cc
index 33baa7eafd2de6769c6a94864fbfb307bc42f926..3db95d81242a6a351da7eded11e69449e93fccc9 100644
--- a/chrome/test/webdriver/webdriver_error.cc
+++ b/chrome/test/webdriver/webdriver_error.cc
@@ -72,6 +72,10 @@ std::string Error::ToString() const {
if (details_.length()) {
error += details_;
}
+
+ // Only include a stacktrace on Linux. Windows and Mac have all symbols
+ // stripped in release builds.
+#if defined(OS_LINUX)
size_t count = 0;
trace_.Addresses(&count);
if (count > 0) {
@@ -80,6 +84,7 @@ std::string Error::ToString() const {
error += "\n";
error += ostream.str();
}
+#endif
return error;
}
« no previous file with comments | « chrome/test/webdriver/session_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698