Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8949)

Unified Diff: chrome/test/webdriver/commands/session_with_id.cc

Issue 6992015: Fix minor issues in ChromeDriver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ... Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/webdriver/commands/create_session.cc ('k') | chrome/test/webdriver/server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/webdriver/commands/session_with_id.cc
diff --git a/chrome/test/webdriver/commands/session_with_id.cc b/chrome/test/webdriver/commands/session_with_id.cc
index 5889be47aacae906dda60f923fb30a400366974b..7c4f00074659e4603b88ea40afc3ded8662f9554 100644
--- a/chrome/test/webdriver/commands/session_with_id.cc
+++ b/chrome/test/webdriver/commands/session_with_id.cc
@@ -51,9 +51,14 @@ void SessionWithID::ExecuteGet(Response* const response) {
temp_value->SetBoolean("javascriptEnabled", true);
// Custom non-standard session info.
- temp_value->SetString("chrome.chromedriverVersion", "1.0");
- temp_value->SetString("chrome.automationVersion", chrome::kChromeVersion);
- temp_value->SetBoolean("chrome.nativeEvents", session_->use_native_events());
+ temp_value->SetWithoutPathExpansion(
+ "chrome.chromedriverVersion", Value::CreateStringValue("1.0"));
+ temp_value->SetWithoutPathExpansion(
+ "chrome.automationVersion",
+ Value::CreateStringValue(chrome::kChromeVersion));
+ temp_value->SetWithoutPathExpansion(
+ "chrome.nativeEvents",
+ Value::CreateBooleanValue(session_->use_native_events()));
response->SetValue(temp_value);
}
« no previous file with comments | « chrome/test/webdriver/commands/create_session.cc ('k') | chrome/test/webdriver/server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698