Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 6987019: Revert 86625 - This change implements a first pass in the effort to remove the dependency of Plat... (Closed)

Created:
9 years, 7 months ago by vandebo (ex-Chrome)
Modified:
9 years, 7 months ago
Reviewers:
Jeff Timanus
CC:
chromium-reviews, hclam+watch_chromium.org, Avi (use Gerrit), sjl, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Erik does not do reviews, Paweł Hajdan Jr., jam, joi+watch-content_chromium.org, Aaron Boodman, acolwell GONE FROM CHROMIUM, annacc, darin-cc_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), pam+watch_chromium.org, brettw-cc_chromium.org, scherkus (not reviewing)
Visibility:
Public.

Description

Revert 86625 - This change implements a first pass in the effort to remove the dependency of PlatformDevice within Chrome. The Skia library now provides multiple back-ends for the SkDevice class, so PlatformDevice's inheritance of SkDevice, and the assumption of instances of PlatformDevice limits the use of these new back-ends. A new set of helper functions is provided for the PlatformDevice entry points. Upon construction of a PlatformDevice, a pointer to the interface is cached in the parent SkDevice's SkMetaData. The new helper functions forward calls to the interface cached in the metadata. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/7019013 TBR=twiz@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86629

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+433 lines, -562 lines) Patch
M chrome/browser/aeropeek_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.cc View 2 chunks +15 lines, -17 lines 0 comments Download
M chrome/browser/tab_contents/thumbnail_generator.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/thumbnail_generator_unittest.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/dragged_tab_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/native_view_photobooth_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/theme_helpers.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 4 chunks +8 lines, -5 lines 0 comments Download
M chrome/renderer/print_web_view_helper_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/print_web_view_helper_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_thumbnailer.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/backing_store_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/backing_store_skia.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/backing_store_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/backing_store_x.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/webplugin_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/webplugin_delegate_proxy.cc View 4 chunks +10 lines, -11 lines 0 comments Download
M ppapi/proxy/ppb_image_data_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/emf_win.h View 1 chunk +1 line, -1 line 0 comments Download
M printing/emf_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/image_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/metafile.h View 2 chunks +4 lines, -2 lines 0 comments Download
M printing/pdf_metafile_cairo_linux.h View 1 chunk +1 line, -2 lines 0 comments Download
M printing/pdf_metafile_cairo_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/pdf_metafile_cg_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M printing/pdf_metafile_cg_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/pdf_metafile_skia.h View 1 chunk +1 line, -2 lines 0 comments Download
M printing/pdf_metafile_skia.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/printed_document_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/printing_context_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M skia/ext/bitmap_platform_device.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/bitmap_platform_device_linux.h View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/bitmap_platform_device_mac.h View 1 chunk +9 lines, -7 lines 0 comments Download
M skia/ext/bitmap_platform_device_mac.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M skia/ext/bitmap_platform_device_win.h View 1 chunk +8 lines, -5 lines 0 comments Download
M skia/ext/bitmap_platform_device_win.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M skia/ext/canvas_paint_linux.h View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/canvas_paint_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/canvas_paint_win.h View 1 chunk +3 lines, -2 lines 0 comments Download
M skia/ext/platform_canvas.h View 3 chunks +29 lines, -47 lines 0 comments Download
M skia/ext/platform_canvas.cc View 3 chunks +18 lines, -20 lines 0 comments Download
M skia/ext/platform_canvas_linux.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M skia/ext/platform_canvas_mac.cc View 2 chunks +9 lines, -1 line 0 comments Download
M skia/ext/platform_canvas_unittest.cc View 13 chunks +26 lines, -18 lines 0 comments Download
M skia/ext/platform_canvas_win.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M skia/ext/platform_device.h View 1 chunk +0 lines, -75 lines 0 comments Download
D skia/ext/platform_device.cc View 1 chunk +0 lines, -74 lines 0 comments Download
M skia/ext/platform_device_linux.h View 2 chunks +2 lines, -7 lines 0 comments Download
M skia/ext/platform_device_linux.cc View 2 chunks +1 line, -8 lines 0 comments Download
M skia/ext/platform_device_mac.h View 2 chunks +2 lines, -9 lines 0 comments Download
M skia/ext/platform_device_mac.cc View 2 chunks +18 lines, -8 lines 0 comments Download
M skia/ext/platform_device_win.h View 3 chunks +5 lines, -6 lines 0 comments Download
M skia/ext/platform_device_win.cc View 3 chunks +12 lines, -12 lines 0 comments Download
M skia/ext/skia_utils_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M skia/ext/vector_canvas.h View 2 chunks +3 lines, -3 lines 0 comments Download
M skia/ext/vector_canvas.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M skia/ext/vector_canvas_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M skia/ext/vector_platform_device_emf_win.h View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/vector_platform_device_emf_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M skia/ext/vector_platform_device_skia.h View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/vector_platform_device_skia.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M skia/skia.gyp View 1 chunk +1 line, -2 lines 0 comments Download
M ui/base/clipboard/clipboard_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/clipboard/clipboard_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/clipboard/clipboard_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/blit.cc View 5 chunks +13 lines, -12 lines 0 comments Download
M ui/gfx/blit_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/canvas_skia.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/canvas_skia_linux.cc View 4 chunks +24 lines, -28 lines 0 comments Download
M ui/gfx/canvas_skia_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/canvas_skia_win.cc View 8 chunks +31 lines, -37 lines 0 comments Download
M ui/gfx/native_theme_win.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M views/controls/menu/menu_win.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M views/controls/menu/native_menu_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M views/controls/table/native_table_win.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M views/controls/table/table_view.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M views/controls/tree/tree_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M views/widget/native_widget_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/webkit_glue.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webmediaplayer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl_gtk.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppb_image_data_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppb_pdf_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_scrollbar_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/sad_plugin.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/mac/webwidget_host.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/test_shell_webthemecontrol.cc View 5 chunks +6 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/webwidget_host_gtk.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webkit/tools/test_shell/webwidget_host_win.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
vandebo (ex-Chrome)
9 years, 7 months ago (2011-05-25 16:15:42 UTC) #1
Jeff Timanus
9 years, 7 months ago (2011-05-25 16:36:24 UTC) #2
On 2011/05/25 16:15:42, vandebo wrote:

LGTM.

Thanks for the revert.

Powered by Google App Engine
This is Rietveld 408576698