Issue 6976042: Turn off optimization for ChildProcessLauncher::Context::TerminateInternal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6976042: Turn off optimization for ChildProcessLauncher::Context::TerminateInternal. (Closed)

Created:
9 years, 7 months ago by apatrick_chromium

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, joi+watch-content_chromium.org, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Turn off optimization for ChildProcessLauncher::Context::TerminateInternal. This is to try and get more information about a crash. BUG=81449 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87052

Patch Set 1 #

Total comments: 1

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	content/browser/child_process_launcher.cc	View		3 chunks	+12 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

9 years, 7 months ago (2011-05-27 17:37:46 UTC) #2

LGTM

http://codereview.chromium.org/6976042/diff/1/content/browser/child_process_l...
File content/browser/child_process_launcher.cc (right):

http://codereview.chromium.org/6976042/diff/1/content/browser/child_process_l...
content/browser/child_process_launcher.cc:14: #include "build/build_config.h"
nit: this header is already included for you by other headers, and normally we
just exclude listing it for that reason.

Expand Messages | Collapse Messages