Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Unified Diff: content/browser/child_process_launcher.cc

Issue 6976042: Turn off optimization for ChildProcessLauncher::Context::TerminateInternal. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/child_process_launcher.cc
===================================================================
--- content/browser/child_process_launcher.cc (revision 86871)
+++ content/browser/child_process_launcher.cc (working copy)
@@ -11,6 +11,7 @@
#include "base/memory/scoped_ptr.h"
#include "base/synchronization/lock.h"
#include "base/threading/thread.h"
+#include "build/build_config.h"
darin (slow to review) 2011/05/27 17:37:46 nit: this header is already included for you by ot
#include "chrome/common/chrome_switches.h"
#include "content/browser/browser_thread.h"
#include "content/browser/content_browser_client.h"
@@ -236,6 +237,13 @@
process_.SetProcessBackgrounded(background);
}
+// TODO(apatrick): Remove this ASAP. http://crbog.com/81449 shows that this is
+// called before later calling null. Disable optimization to try and get more
+// information about what happened here.
+#if defined(OS_WIN)
+#pragma optimize("", off)
+#endif
+
static void TerminateInternal(
#if defined(OS_LINUX)
bool zygote,
@@ -261,6 +269,10 @@
process.Close();
}
+#if defined(OS_WIN)
+#pragma optimize("", on)
+#endif
+
Client* client_;
BrowserThread::ID client_thread_id_;
base::Process process_;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698