Turn off optimization for ChildProcessLauncher::Context::TerminateInternal.

content/browser/child_process_launcher.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/child_process_launcher.h"
 
 #include <utility>  // For std::pair.
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/synchronization/lock.h"
 #include "base/threading/thread.h"
+#include "build/build_config.h"

[darin (slow to review), 2011/05/27 17:37:46]

nit: this header is already included for you by other headers, and normally we
just exclude listing it for that reason.

 #include "chrome/common/chrome_switches.h"
 #include "content/browser/browser_thread.h"
 #include "content/browser/content_browser_client.h"
 #include "content/common/chrome_descriptors.h"
 #include "content/common/process_watcher.h"
 #include "content/common/result_codes.h"
 
 #if defined(OS_WIN)
 #include "base/file_path.h"
 #include "chrome/common/sandbox_policy.h"
@@ skipping 205 matching lines @@
 #endif
             process_.handle()));
     process_.set_handle(base::kNullProcessHandle);
   }
 
   void SetProcessBackgrounded(bool background) {
     DCHECK(!starting_);
     process_.SetProcessBackgrounded(background);
   }
 
+// TODO(apatrick): Remove this ASAP. http://crbog.com/81449 shows that this is
+// called before later calling null. Disable optimization to try and get more
+// information about what happened here.
+#if defined(OS_WIN)
+#pragma optimize("", off)
+#endif
+
   static void TerminateInternal(
 #if defined(OS_LINUX)
       bool zygote,
 #endif
       base::ProcessHandle handle) {
     base::Process process(handle);
      // Client has gone away, so just kill the process.  Using exit code 0
     // means that UMA won't treat this as a crash.
     process.Terminate(ResultCodes::NORMAL_EXIT);
     // On POSIX, we must additionally reap the child.
 #if defined(OS_POSIX)
 #if defined(OS_LINUX)
     if (zygote) {
       // If the renderer was created via a zygote, we have to proxy the reaping
       // through the zygote process.
       ZygoteHost::GetInstance()->EnsureProcessTerminated(handle);
     } else
 #endif  // OS_LINUX
     {
       ProcessWatcher::EnsureProcessTerminated(handle);
     }
 #endif  // OS_POSIX
     process.Close();
   }
 
+#if defined(OS_WIN)
+#pragma optimize("", on)
+#endif
+
   Client* client_;
   BrowserThread::ID client_thread_id_;
   base::Process process_;
   bool starting_;
   // Controls whether the child process should be terminated on browser
   // shutdown. Default behavior is to terminate the child.
   bool terminate_child_on_shutdown_;
 
 #if defined(OS_LINUX)
   bool zygote_;
@@ skipping 70 matching lines @@
           &ChildProcessLauncher::Context::SetProcessBackgrounded,
           background));
 }
 
 void ChildProcessLauncher::SetTerminateChildOnShutdown(
   bool terminate_on_shutdown) {
   if (context_)
     context_->set_terminate_child_on_shutdown(terminate_on_shutdown);
 }