Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 6975051: Remove COMPOSITOR_2 flag, old compositor code. (Closed)

Created:
9 years, 6 months ago by wjmaclean
Modified:
9 years, 6 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, backer
Visibility:
Public.

Description

Remove COMPOSITOR_2 flag, old compositor code. BUG=none TEST=compiles, run manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88671

Patch Set 1 #

Patch Set 2 : Gardened against dirty texture patch. #

Patch Set 3 : Gardened, fixed views unit test. #

Patch Set 4 : Change conditional compile defines. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -228 lines) Patch
M build/common.gypi View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/wrench_menu.cc View 1 2 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/test/unit/chrome_test_suite.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/compositor/compositor.h View 1 2 2 chunks +0 lines, -42 lines 0 comments Download
M ui/gfx/compositor/compositor_gl.cc View 1 2 2 chunks +0 lines, -67 lines 0 comments Download
M views/run_all_unittests.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M views/view.h View 1 2 4 chunks +0 lines, -19 lines 0 comments Download
M views/view.cc View 1 2 3 15 chunks +3 lines, -70 lines 0 comments Download
M views/view_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M views/widget/root_view.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M views/widget/root_view.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M views/widget/widget.cc View 1 2 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
wjmaclean
Currently running on the try bots.
9 years, 6 months ago (2011-05-31 21:07:33 UTC) #1
sadrul
Nice. Thanks!
9 years, 6 months ago (2011-05-31 21:18:10 UTC) #2
sky
LGTM
9 years, 6 months ago (2011-05-31 22:09:08 UTC) #3
wjmaclean
Holding off on landing this as it has exposed some bugs in the GL surface ...
9 years, 6 months ago (2011-06-01 16:49:50 UTC) #4
sky
9 years, 6 months ago (2011-06-10 16:39:47 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698