Remove the Remoting Host component from Chrome.

Remove the Remoting Host component from Chrome.

* Update the Remoting feature flag description.
* Fix license headers.
* Remove files from gyp definitions.
* Remove Chromoting trigger for Service Process launch on browser startup, and Chromoting setup HTML resources.
* Remove Chromoting Host registration components from Browser.
* Remove resources for Chromoting Host options UI.
* Remove Service Process control APIs for Chromoting Host.
* Remove Chromoting Host prefs from Browser UI.
* Remove WebUI for Chromoting Host.
* Remove WebUI options for Chromoting Host.
* Remove Chromoting Host policy options, and don't warn if Chromoting is entirely disabled by policy, since there are no user-visible settings for it anyway.
* Remove Chromoting Host preference names, service IPCs and URL constants.
* Remove Chromoting Host from Service Process.
* Remove remoting strings, locale settings and setup "Id".

BUG=
TEST=Run Service Process from a profile in which Chromoting Host had previously been configured, and Cloud Print NOT configured.  Chromoting Host should not be accessible, and Service Process should quit after about a minute.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84819

[Wez, 2011-05-06 22:22:29]

Removing the Chromoting Host component from the Chrome Service Process.

sergeyu: Remoting Host registration/setup flows & UI. (i.e.
chrome/browser/remoting, chrome/browser/ui)

sanjeevr: Service Process stuff (i.e. chrome/service, 
chrome/browser/browser_main and chrome/browser/service)

garykac: Prefs & policy (i.e. chrome/browser/policy and
chrome/common/prefs_names, etc)

(To start with... looks like another few people have to LGTM it, too, because it
touches so many directories...)

[Lambros (do not use), 2011-05-06 22:35:14]

Does this mean we can remove the libpam dependency?  Here's the original CL
which added it:
http://codereview.chromium.org/6484002

Lambros


On Fri, May 6, 2011 at 3:22 PM, <wez@chromium.org> wrote:

> Reviewers: sergeyu, sanjeevr, garykac,
>
> Message:
> Removing the Chromoting Host component from the Chrome Service Process.
>
> sergeyu: Remoting Host registration/setup flows & UI. (i.e.
> chrome/browser/remoting, chrome/browser/ui)
>
> sanjeevr: Service Process stuff (i.e. chrome/service,
> chrome/browser/browser_main and chrome/browser/service)
>
> garykac: Prefs & policy (i.e. chrome/browser/policy and
> chrome/common/prefs_names, etc)
>
> (To start with... looks like another few people have to LGTM it, too,
> because it
> touches so many directories...)
>
>
> Description:
> Remove the Remoting Host component from Chrome.
>
> * Update the Remoting feature flag description.
> * Fix license headers.
> * Remove files from gyp definitions.
> * Remove Chromoting trigger for Service Process launch on browser startup,
> and
> Chromoting setup HTML resources.
> * Remove Chromoting Host registration components from Browser.
> * Remove resources for Chromoting Host options UI.
> * Remove Service Process control APIs for Chromoting Host.
> * Remove Chromoting Host prefs from Browser UI.
> * Remove WebUI for Chromoting Host.
> * Remove WebUI options for Chromoting Host.
> * Remove Chromoting Host policy options, and don't warn if Chromoting is
> entirely disabled by policy, since there are no user-visible settings for
> it
> anyway.
> * Remove Chromoting Host preference names, service IPCs and URL constants.
> * Remove Chromoting Host from Service Process.
> * Remove remoting strings, locale settings and setup "Id".
>
> BUG=
> TEST=Run Service Process from a profile in which Chromoting Host had
> previously
> been configured, and Cloud Print NOT configured.  Chromoting Host should
> not be
> accessible, and Service Process should quit after about a minute.
>
>
> Please review this at http://codereview.chromium.org/6955010/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/app/chrome_command_ids.h
>  M chrome/app/generated_resources.grd
>  M chrome/app/resources/locale_settings.grd
>  M chrome/browser/browser_main.cc
>  M chrome/browser/browser_resources.grd
>  M chrome/browser/policy/configuration_policy_pref_store.cc
>  M chrome/browser/policy/configuration_policy_pref_store_unittest.cc
>  M chrome/browser/policy/managed_prefs_banner_base.cc
>  D chrome/browser/remoting/directory_add_request.h
>  D chrome/browser/remoting/directory_add_request.cc
>  D chrome/browser/remoting/directory_add_request_unittest.cc
>  D chrome/browser/remoting/remoting_options_handler.h
>  D chrome/browser/remoting/remoting_options_handler.cc
>  D chrome/browser/remoting/remoting_resources_source.h
>  D chrome/browser/remoting/remoting_resources_source.cc
>  D chrome/browser/remoting/resources/remoting_setting_up.html
>  D chrome/browser/remoting/resources/remoting_setup_done.html
>  D chrome/browser/remoting/resources/remoting_setup_error.html
>  D chrome/browser/remoting/resources/remoting_setup_flow.css
>  D chrome/browser/remoting/resources/remoting_setup_flow.html
>  D chrome/browser/remoting/setup_flow.h
>  D chrome/browser/remoting/setup_flow.cc
>  D chrome/browser/remoting/setup_flow_get_status_step.h
>  D chrome/browser/remoting/setup_flow_get_status_step.cc
>  D chrome/browser/remoting/setup_flow_login_step.h
>  D chrome/browser/remoting/setup_flow_login_step.cc
>  D chrome/browser/remoting/setup_flow_register_step.h
>  D chrome/browser/remoting/setup_flow_register_step.cc
>  D chrome/browser/remoting/setup_flow_start_host_step.h
>  D chrome/browser/remoting/setup_flow_start_host_step.cc
>  M chrome/browser/resources/options/advanced_options.html
>  M chrome/browser/resources/options/advanced_options.js
>  M chrome/browser/service/service_process_control.h
>  M chrome/browser/service/service_process_control.cc
>  M chrome/browser/service/service_process_control_browsertest.cc
>  M chrome/browser/tab_contents/render_view_context_menu.cc
>  M chrome/browser/ui/browser.h
>  M chrome/browser/ui/browser.cc
>  M chrome/browser/ui/webui/chrome_web_ui_factory.cc
>  M chrome/browser/ui/webui/options/advanced_options_handler.h
>  M chrome/browser/ui/webui/options/advanced_options_handler.cc
>  D chrome/browser/ui/webui/remoting_ui.h
>  D chrome/browser/ui/webui/remoting_ui.cc
>  M chrome/chrome.gyp
>  M chrome/chrome_browser.gypi
>  M chrome/chrome_tests.gypi
>  M chrome/common/pref_names.h
>  M chrome/common/pref_names.cc
>  M chrome/common/service_messages.h
>  M chrome/common/url_constants.h
>  M chrome/common/url_constants.cc
>  M chrome/service/DEPS
>  D chrome/service/remoting/chromoting_host_manager.h
>  D chrome/service/remoting/chromoting_host_manager.cc
>  M chrome/service/service_ipc_server.h
>  M chrome/service/service_ipc_server.cc
>  M chrome/service/service_process.h
>  M chrome/service/service_process.cc
>  M chrome/service/service_process_unittest.cc
>
>
>

[Wez, 2011-05-06 22:47:17]

On 2011/05/06 22:35:14, lambroslambrou wrote:
> Does this mean we can remove the libpam dependency?  Here's the original CL
> which added it:
> http://codereview.chromium.org/6484002
> 
> Lambros

No; this CL just removes the remoting dependencies from Chrome itself - PAM is
still required by the chromoting_simple_host.

[Sergey Ulanov, 2011-05-06 22:55:17]

http://codereview.chromium.org/6955010/diff/1/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (left):

http://codereview.chromium.org/6955010/diff/1/chrome/browser/ui/browser.cc#ol...
chrome/browser/ui/browser.cc:2093:
prefs->RegisterBooleanPref(prefs::kChromotingEnabled, false);
Do we still need this?

http://codereview.chromium.org/6955010/diff/1/chrome/chrome.gyp
File chrome/chrome.gyp (right):

http://codereview.chromium.org/6955010/diff/1/chrome/chrome.gyp#newcode821
chrome/chrome.gyp:821: '../remoting/remoting.gyp:chromoting_host',
Don't need this dependency anymore

[sanjeevr, 2011-05-09 17:33:56]

LGTM for chrome/service code

[Wez, 2011-05-09 20:37:34]

Addressed sergeyu@'s comments (see below).

Also removed unused ChromotingHostInfo class, and Chromoting policy templates.

On 2011/05/06 22:55:17, sergeyu wrote:
> http://codereview.chromium.org/6955010/diff/1/chrome/browser/ui/browser.cc
> File chrome/browser/ui/browser.cc (left):
> 
>
http://codereview.chromium.org/6955010/diff/1/chrome/browser/ui/browser.cc#ol...
> chrome/browser/ui/browser.cc:2093:
> prefs->RegisterBooleanPref(prefs::kChromotingEnabled, false);
> Do we still need this?

No; I'd confused it with the EnableRemoting flag and so left it in by mistake.

> http://codereview.chromium.org/6955010/diff/1/chrome/chrome.gyp
> File chrome/chrome.gyp (right):
> 
> http://codereview.chromium.org/6955010/diff/1/chrome/chrome.gyp#newcode821
> chrome/chrome.gyp:821: '../remoting/remoting.gyp:chromoting_host',
> Don't need this dependency anymore

Done.

[Sergey Ulanov, 2011-05-09 22:05:10]

LGTM

[garykac, 2011-05-09 22:40:39]

Policy stuff LGTM

Note that I'll need to follow up and re-add the main ChromotingEnabled kill
switch option, but it'll be connected to the command line flag, so it'll be a
bit different.

[commit-bot: I haz the power, 2011-05-09 22:49:23]

Presubmit check for 6955010-4001 failed and returned exit status 1.

Running presubmit commit checks ...
Finished checking
/mnt/data/b/commit-queue/workdir/chromium/chrome/app/policy/policy_templates.json.
0 errors, 0 warnings.

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  chrome/app/generated_resources.grd, line 4061, 182 chars

Presubmit checks took 1.9s to calculate.