Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 6930014: Rename ClientSocket to StreamSocket. (Closed)

Created:
9 years, 7 months ago by Sergey Ulanov
Modified:
9 years, 7 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, cbentzel+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, Paweł Hajdan Jr., jam, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, pam+watch_chromium.org, ajwong+watch_chromium.org, darin-cc_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Rename ClientSocket to StreamSocket. BUG=80895 TEST=Compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84167

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -229 lines) Patch
M content/browser/renderer_host/p2p/socket_host_tcp.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp_server.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp_server.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp_server_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_host_test_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M jingle/glue/pseudotcp_adapter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M jingle/notifier/base/chrome_async_socket.h View 2 chunks +2 lines, -2 lines 0 comments Download
M jingle/notifier/base/chrome_async_socket_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/base/fake_ssl_client_socket.h View 6 chunks +7 lines, -7 lines 0 comments Download
M jingle/notifier/base/fake_ssl_client_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/base/fake_ssl_client_socket_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M jingle/notifier/base/proxy_resolving_client_socket.h View 4 chunks +4 lines, -4 lines 0 comments Download
M jingle/notifier/base/resolving_client_socket_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M jingle/notifier/base/xmpp_client_socket_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M jingle/notifier/base/xmpp_client_socket_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/base/net_log_event_type_list.h View 1 chunk +1 line, -1 line 0 comments Download
M net/ftp/ftp_network_transaction.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/ftp/ftp_network_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_proxy_client_socket.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_proxy_client_socket_pool.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_proxy_client_socket_pool.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/proxy_client_socket.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/net.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/client_socket_factory.h View 3 chunks +5 lines, -5 lines 0 comments Download
M net/socket/client_socket_factory.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/socket/client_socket_handle.h View 5 chunks +7 lines, -7 lines 0 comments Download
M net/socket/client_socket_pool.h View 3 chunks +4 lines, -4 lines 0 comments Download
M net/socket/client_socket_pool_base.h View 9 chunks +10 lines, -10 lines 0 comments Download
M net/socket/client_socket_pool_base.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M net/socket/client_socket_pool_base_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M net/socket/deterministic_socket_data_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/server_socket.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/socket_test_util.h View 12 chunks +12 lines, -12 lines 0 comments Download
M net/socket/socket_test_util.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M net/socket/socks5_client_socket.h View 3 chunks +6 lines, -6 lines 0 comments Download
M net/socket/socks5_client_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/socks5_client_socket_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/socks_client_socket.h View 3 chunks +5 lines, -5 lines 0 comments Download
M net/socket/socks_client_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/socks_client_socket_pool.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/socks_client_socket_pool.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/socks_client_socket_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/ssl_client_socket_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_nss.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_openssl.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_openssl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_pool.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/ssl_client_socket_unittest.cc View 12 chunks +12 lines, -12 lines 0 comments Download
M net/socket/ssl_client_socket_win.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_server_socket_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + net/socket/stream_socket.h View 5 chunks +7 lines, -7 lines 0 comments Download
A + net/socket/stream_socket.cc View 5 chunks +11 lines, -11 lines 0 comments Download
M net/socket/tcp_client_socket_libevent.h View 3 chunks +3 lines, -3 lines 0 comments Download
M net/socket/tcp_client_socket_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/socket/tcp_server_socket_libevent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/socket/tcp_server_socket_libevent.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/tcp_server_socket_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M net/socket/tcp_server_socket_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/socket/tcp_server_socket_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/transport_client_socket_pool.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/transport_client_socket_pool.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/transport_client_socket_pool_unittest.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M net/socket/transport_client_socket_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket_stream/socket_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket_stream/socket_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket_stream/socket_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_proxy_client_socket.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_proxy_client_socket.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_session.h View 1 chunk +1 line, -1 line 0 comments Download
M net/udp/udp_socket_libevent.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/jingle_glue/ssl_socket_adapter.h View 3 chunks +4 lines, -4 lines 0 comments Download
M remoting/protocol/jingle_session.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/jingle_session.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Sergey Ulanov
9 years, 7 months ago (2011-05-04 19:14:17 UTC) #1
willchan no longer on Chromium
I spent a bit of time wondering if we should change ClientSocketHandle/ClientSocketFactory/ClientSocketPool too. Those are ...
9 years, 7 months ago (2011-05-04 19:30:28 UTC) #2
Sergey Ulanov
On 2011/05/04 19:30:28, willchan wrote: > I spent a bit of time wondering if we ...
9 years, 7 months ago (2011-05-04 19:37:36 UTC) #3
willchan no longer on Chromium
9 years, 7 months ago (2011-05-04 19:41:23 UTC) #4
Let's wait until I can talk it over with Mike, next Monday. Thanks for
helping out!

On Wed, May 4, 2011 at 3:37 PM, <sergeyu@chromium.org> wrote:

> On 2011/05/04 19:30:28, willchan wrote:
>
>> I spent a bit of time wondering if we should change
>> ClientSocketHandle/ClientSocketFactory/ClientSocketPool too. Those are
>>
> probably
>
>> only useful on the client side, so maybe they make sense as is. I will
>> confer
>> with mbelshe later (he's out this week). So, this LGTM as is. Thanks!
>>
> IMHO it makes sense to rename ClientSocketFactory too (I want to do it in a
> separate CL). Not sure about ClientSocketHandle and ClientSocketPool.
>
>
>
> http://codereview.chromium.org/6930014/
>

Powered by Google App Engine
This is Rietveld 408576698