Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6930013: Re-committing http://codereview.chromium.org/6803005/ after fixing multi-dll build: (Closed)

Created:
9 years, 7 months ago by GeorgeY
Modified:
9 years, 6 months ago
Reviewers:
dhollowa
CC:
chromium-reviews, jshin+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Re-committing http://codereview.chromium.org/6803005/ after fixing multi-dll build: Autofill phone number enhancements and integration of Phone Number Util Library: part 1 Temporarily the whole library is included, until the patch is upstreamed. BUG=71443 TEST=Unit-tested Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84174

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31866 lines, -0 lines) Patch
M build/all.gyp View 9 chunks +9 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/libphonenumber/README.chromium View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/libphonenumber/chrome/regexp_adapter_icuregexp.cc View 1 chunk +299 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/CMakeLists.txt View 1 chunk +242 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/LICENSE View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/README View 1 chunk +69 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/base/singleton.h View 1 chunk +271 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/default_logger.h View 1 chunk +56 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/default_logger.cc View 1 chunk +63 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/logger_adapter.h View 1 chunk +48 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/logger_adapter.cc View 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/metadata.h View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/metadata.cc View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/phonenumber.h View 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/phonenumber.cc View 1 chunk +87 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/phonenumberutil.h View 1 chunk +678 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/phonenumberutil.cc View 1 chunk +2266 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/phonenumberutil_test.cc View 1 chunk +2866 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/re2_cache.h View 1 chunk +83 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/re2_cache.cc View 1 chunk +75 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/re2_cache_test.cc View 1 chunk +63 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/regexp_adapter.h View 1 chunk +96 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/regexp_adapter_re2.cc View 1 chunk +192 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/regexp_adapter_unittest.cc View 1 chunk +142 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/run_tests.cc View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/stringutil.h View 1 chunk +125 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/stringutil.cc View 1 chunk +273 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/stringutil_test.cc View 1 chunk +208 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/test_metadata.h View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/test_metadata.cc View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/utf/README View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/utf/rune.c View 1 chunk +350 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/utf/stringpiece.h View 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/utf/stringprintf.h View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/utf/unicodetext.h View 1 chunk +456 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/utf/unicodetext.cc View 1 chunk +515 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/utf/unilib.h View 1 chunk +95 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/utf/unilib.cc View 1 chunk +64 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/utf/utf.h View 1 chunk +251 lines, -0 lines 0 comments Download
A third_party/libphonenumber/cpp/src/utf/utfdef.h View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/libphonenumber/libphonenumber.gyp View 1 chunk +139 lines, -0 lines 0 comments Download
A third_party/libphonenumber/patches/version186.patch View 1 chunk +1177 lines, -0 lines 0 comments Download
A third_party/libphonenumber/resources/PhoneNumberMetaData.xml View 1 chunk +19202 lines, -0 lines 0 comments Download
A third_party/libphonenumber/resources/PhoneNumberMetaDataForTesting.xml View 1 chunk +764 lines, -0 lines 0 comments Download
A third_party/libphonenumber/resources/phonemetadata.proto View 1 chunk +235 lines, -0 lines 0 comments Download
A third_party/libphonenumber/resources/phonenumber.proto View 1 chunk +121 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
GeorgeY
It is the same as first attempt, but with multi-dll fixes for GYP.
9 years, 7 months ago (2011-05-04 23:24:58 UTC) #1
dhollowa
9 years, 7 months ago (2011-05-04 23:31:08 UTC) #2 
LGTM (Rubber stamp).

Powered by Google App Engine
This is Rietveld 408576698