String->URL cleanup, chromium-side.

This goes in first, followed by a webkit change that defines WEBFILESYSTEMCALLBACKS_USE_URL_NOT_STRING, followed by a cleanup in Chromium [deletions only], followed by deleting that definition in webkit.

Here's the first webkit change: https://bugs.webkit.org/show_bug.cgi?id=60218.

BUG=NONE
TEST=existing tests; no functionality change is intended


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87572

[kinuko, 2011-04-28 12:43:31]

http://codereview.chromium.org/6904063/diff/1/webkit/tools/test_shell/simple_...
File webkit/tools/test_shell/simple_file_system.cc (right):

http://codereview.chromium.org/6904063/diff/1/webkit/tools/test_shell/simple_...
webkit/tools/test_shell/simple_file_system.cc:181: const WebString& dest_path,
nit: indent

[ericu, 2011-05-05 18:36:32]

This is now ready for review.

[kinuko, 2011-05-06 07:46:57]

lgtm

http://codereview.chromium.org/6904063/diff/2001/webkit/tools/test_shell/simp...
File webkit/tools/test_shell/simple_file_system.cc (right):

http://codereview.chromium.org/6904063/diff/2001/webkit/tools/test_shell/simp...
webkit/tools/test_shell/simple_file_system.cc:184: const WebString& dest_path,
nit: indent (here and below)

[ericu, 2011-05-11 22:02:18]

http://codereview.chromium.org/6904063/diff/2001/webkit/tools/test_shell/simp...
File webkit/tools/test_shell/simple_file_system.cc (right):

http://codereview.chromium.org/6904063/diff/2001/webkit/tools/test_shell/simp...
webkit/tools/test_shell/simple_file_system.cc:184: const WebString& dest_path,
On 2011/05/06 07:46:57, kinuko wrote:
> nit: indent (here and below)

Done, thanks; I'm not sure how I did that.

[darin (slow to review), 2011-05-20 22:40:31]

LGTM

http://codereview.chromium.org/6904063/diff/7001/content/common/file_system/w...
File content/common/file_system/webfilesystem_impl.cc (right):

http://codereview.chromium.org/6904063/diff/7001/content/common/file_system/w...
content/common/file_system/webfilesystem_impl.cc:125:
move(WebURL(GURL(src_path)), WebURL(GURL(dest_path)), callbacks);
you shouldn't need to explicitly call the WebURL constructor given a GURL.  that
one happens implicitly.  it would probably help with readability if
WebURL(GURL(...)) were reduced to GURL(...) everywhere.

[ericu, 2011-06-02 00:25:46]

http://codereview.chromium.org/6904063/diff/7001/content/common/file_system/w...
File content/common/file_system/webfilesystem_impl.cc (right):

http://codereview.chromium.org/6904063/diff/7001/content/common/file_system/w...
content/common/file_system/webfilesystem_impl.cc:125:
move(WebURL(GURL(src_path)), WebURL(GURL(dest_path)), callbacks);
On 2011/05/20 22:40:31, darin wrote:
> you shouldn't need to explicitly call the WebURL constructor given a GURL. 
that
> one happens implicitly.  it would probably help with readability if
> WebURL(GURL(...)) were reduced to GURL(...) everywhere.

Removed unnecessary WebURL constructors throughout.

[commit-bot: I haz the power, 2011-06-02 01:58:56]

Change committed as 87572