Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Unified Diff: webkit/fileapi/file_system_util.cc

Issue 6904063: String->URL cleanup, chromium-side. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove unnecessary WebURL constructors. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/file_system/webfilesystem_impl.cc ('k') | webkit/tools/test_shell/simple_file_system.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/fileapi/file_system_util.cc
diff --git a/webkit/fileapi/file_system_util.cc b/webkit/fileapi/file_system_util.cc
index 80b22e424d1cef098aef28dfbec2d418a58c68e4..ff2024fa49914e689dc0ac57db0eda3eb26449e1 100644
--- a/webkit/fileapi/file_system_util.cc
+++ b/webkit/fileapi/file_system_util.cc
@@ -36,8 +36,9 @@ bool CrackFileSystemURL(const GURL& url, GURL* origin_url, FileSystemType* type,
return false;
std::string temp = url.path();
- // TODO(ericu) remove this code when that ceases to be true, which should be
- // soon.
+ // TODO(ericu) remove this code when that ceases to be true, which will be as
+ // soon as the WEBFILESYSTEMCALLBACKS_USE_URL_NOT_STRING macro goes into
+ // WebKit.
// On Windows, this will have backslashes for now.
// url will look something like:
// filesystem:http://example.com/temporary/\dir\file.txt
@@ -63,8 +64,7 @@ bool CrackFileSystemURL(const GURL& url, GURL* origin_url, FileSystemType* type,
}
// bare_url will look something like:
- // http://example.com/temporary//dir/file.txt [on Windows; the double slash
- // before dir will be single on posix].
+ // http://example.com/temporary/dir/file.txt.
GURL bare_url(temp);
// The input URL was malformed, bail out early.
« no previous file with comments | « content/common/file_system/webfilesystem_impl.cc ('k') | webkit/tools/test_shell/simple_file_system.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698