Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6111)

Unified Diff: chrome/browser/ui/event_disposition_utils.h

Issue 6893046: added CTRL+Click and SHIFT+Click handler for context menu, Back and Forward. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: make event_utils::DispositionFromEventFlags not view-specific. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/event_disposition_utils.h
diff --git a/chrome/browser/ui/views/event_utils.h b/chrome/browser/ui/event_disposition_utils.h
similarity index 61%
copy from chrome/browser/ui/views/event_utils.h
copy to chrome/browser/ui/event_disposition_utils.h
index 9d37c531025bbe033980862b1004c92b5b3a7ccc..aeecdaebe534527e2f3c9c57a114e8e62f30eb45 100644
--- a/chrome/browser/ui/views/event_utils.h
+++ b/chrome/browser/ui/event_disposition_utils.h
@@ -2,16 +2,12 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_UI_VIEWS_EVENT_UTILS_H__
-#define CHROME_BROWSER_UI_VIEWS_EVENT_UTILS_H__
+#ifndef CHROME_BROWSER_UI_EVENT_DISPOSITION_UTILS_H__
brettw 2011/05/31 06:09:06 I probably wouldn't have kept "utils" in the filen
shinyak (Google) 2011/06/09 02:29:04 Done.
+#define CHROME_BROWSER_UI_EVENT_DISPOSITION_UTILS_H__
#pragma once
#include "webkit/glue/window_open_disposition.h"
-namespace views {
-class MouseEvent;
-}
-
namespace event_utils {
brettw 2011/05/31 06:09:06 Seems like this should be "namespace ui"
Ben Goodger (Google) 2011/05/31 16:00:00 Probably namespace browser if nothing else. If it'
shinyak (Google) 2011/06/09 02:29:04 Done.
// Translates event flags into what kind of disposition they represents.
@@ -19,10 +15,6 @@ namespace event_utils {
// event_flags are the flags as understood by views::MouseEvent.
WindowOpenDisposition DispositionFromEventFlags(int event_flags);
-// Returns true if the specified mouse event may have a
-// WindowOptionDisposition.
-bool IsPossibleDispositionEvent(const views::MouseEvent& event);
-
}
-#endif // CHROME_BROWSER_UI_VIEWS_EVENT_UTILS_H__
+#endif // CHROME_BROWSER_UI_EVENT_DISPOSITION_UTILS_H__

Powered by Google App Engine
This is Rietveld 408576698