chrome/browser/ui/event_disposition_utils.cc - Issue 6893046: added CTRL+Click and SHIFT+Click handler for context menu, Back and Forward.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/event_disposition_utils.cc

Issue 6893046: added CTRL+Click and SHIFT+Click handler for context menu, Back and Forward. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: make event_utils::DispositionFromEventFlags not view-specific. Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/event_disposition_utils.h ('K') | « chrome/browser/ui/event_disposition_utils.h ('k') | chrome/browser/ui/gtk/gtk_util.h » ('j') | chrome/browser/ui/tab_contents/tab_contents_wrapper_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/event_disposition_utils.cc

diff --git a/chrome/browser/ui/views/event_utils.cc b/chrome/browser/ui/event_disposition_utils.cc

similarity index 77%

copy from chrome/browser/ui/views/event_utils.cc

copy to chrome/browser/ui/event_disposition_utils.cc

index 49d021398c32bf9b46812727c133705a83e1300a..b9198776bd8beab140592d82df37acd1b4280724 100644

--- a/chrome/browser/ui/views/event_utils.cc

+++ b/chrome/browser/ui/event_disposition_utils.cc

@@ -5,9 +5,7 @@

#include "chrome/browser/ui/views/event_utils.h"

#include "content/browser/disposition_utils.h"

-#include "views/events/event.h"

-using views::Event;

+#include "ui/base/events.h"

namespace event_utils {

@@ -20,8 +18,4 @@ WindowOpenDisposition DispositionFromEventFlags(int event_flags) {

(event_flags & ui::EF_SHIFT_DOWN) != 0);

}

-bool IsPossibleDispositionEvent(const views::MouseEvent& event) {

- return event.IsLeftMouseButton() || event.IsMiddleMouseButton();

}