chrome/browser/ui/event_disposition_utils.h - Issue 6893046: added CTRL+Click and SHIFT+Click handler for context menu, Back and Forward.

Side by Side Diff: chrome/browser/ui/event_disposition_utils.h

Issue 6893046: added CTRL+Click and SHIFT+Click handler for context menu, Back and Forward. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: make event_utils::DispositionFromEventFlags not view-specific. Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/ui/browser_back_forward_navigator.h ('K') | « chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.mm ('k') | chrome/browser/ui/event_disposition_utils.cc » ('j') | chrome/browser/ui/tab_contents/tab_contents_wrapper_delegate.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_VIEWS_EVENT_UTILS_H__	5 #ifndef CHROME_BROWSER_UI_EVENT_DISPOSITION_UTILS_H__
	brettw 2011/05/31 06:09:06 I probably wouldn't have kept "utils" in the filen I probably wouldn't have kept "utils" in the filename. That's a bad practice we're trying to get away from since it doesn't mean anything. Maybe just event_disposition? shinyak (Google) 2011/06/09 02:29:04 Done. Show quoted text On 2011/05/31 06:09:06, brettw wrote: > I probably wouldn't have kept "utils" in the filename. That's a bad practice > we're trying to get away from since it doesn't mean anything. Maybe just > event_disposition? Done.
6 #define CHROME_BROWSER_UI_VIEWS_EVENT_UTILS_H__	6 #define CHROME_BROWSER_UI_EVENT_DISPOSITION_UTILS_H__

7 #pragma once	7 #pragma once

8	8

9 #include "webkit/glue/window_open_disposition.h"	9 #include "webkit/glue/window_open_disposition.h"

10	10

11 namespace views {

12 class MouseEvent;

13 }

14

15 namespace event_utils {	11 namespace event_utils {
	brettw 2011/05/31 06:09:06 Seems like this should be "namespace ui" Seems like this should be "namespace ui" Ben Goodger (Google) 2011/05/31 16:00:00 Probably namespace browser if nothing else. If it' Probably namespace browser if nothing else. If it's going to be namespace ui it should be nested inside namespace browser so it doesn't conflict with code from src/ui. shinyak (Google) 2011/06/09 02:29:04 Done. Show quoted text On 2011/05/31 16:00:00, Ben Goodger wrote: > Probably namespace browser if nothing else. If it's going to be namespace ui it > should be nested inside namespace browser so it doesn't conflict with code from > src/ui. > Done.
16	12

17 // Translates event flags into what kind of disposition they represents.	13 // Translates event flags into what kind of disposition they represents.

18 // For example, a middle click would mean to open a background tab.	14 // For example, a middle click would mean to open a background tab.

19 // event_flags are the flags as understood by views::MouseEvent.	15 // event_flags are the flags as understood by views::MouseEvent.

20 WindowOpenDisposition DispositionFromEventFlags(int event_flags);	16 WindowOpenDisposition DispositionFromEventFlags(int event_flags);

21	17

22 // Returns true if the specified mouse event may have a

23 // WindowOptionDisposition.

24 bool IsPossibleDispositionEvent(const views::MouseEvent& event);

25

26 }	18 }

27	19

28 #endif // CHROME_BROWSER_UI_VIEWS_EVENT_UTILS_H__	20 #endif // CHROME_BROWSER_UI_EVENT_DISPOSITION_UTILS_H__

OLD	NEW