chrome/browser/ui/webui/html_dialog_tab_contents_delegate.cc - Issue 6881073: Cleanup popup related browser navigation code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/html_dialog_tab_contents_delegate.cc

Issue 6881073: Cleanup popup related browser navigation code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase and merge with avi's popup block changes. Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/html_dialog_tab_contents_delegate.cc

diff --git a/chrome/browser/ui/webui/html_dialog_tab_contents_delegate.cc b/chrome/browser/ui/webui/html_dialog_tab_contents_delegate.cc

index 88239cb082568013e51507fce34cef1b33075d06..45fff806b0cd8898ad1ddf61d4da94534edf1b60 100644

--- a/chrome/browser/ui/webui/html_dialog_tab_contents_delegate.cc

+++ b/chrome/browser/ui/webui/html_dialog_tab_contents_delegate.cc

@@ -44,6 +44,7 @@ void HtmlDialogTabContentsDelegate::OpenURLFromTab(

else

params.disposition = disposition;

params.window_action = browser::NavigateParams::SHOW_WINDOW;

+ params.user_gesture = true;

browser::Navigate(&params);

}

@@ -71,6 +72,7 @@ void HtmlDialogTabContentsDelegate::AddNewContents(

params.disposition = disposition;

params.window_bounds = initial_pos;

params.window_action = browser::NavigateParams::SHOW_WINDOW;

+ params.user_gesture = true;

browser::Navigate(&params);

}