Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6880073: Plumb direction of document title through IPC layer. (Closed)

Created:
9 years, 8 months ago by Evan Martin
Modified:
9 years, 7 months ago
CC:
chromium-reviews, tburkard+watch_chromium.org, cbentzel+watch_chromium.org, jam, Avi (use Gerrit), brettw-cc_chromium.org
Visibility:
Public.

Description

Plumb direction of document title through IPC layer. It's ignored at the other end of the IPC, but I have tagged all the places it needs to be obeyed with a link to the bug. While I'm at it, switch UpdateTitle to using string16. BUG=27094 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82400

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -31 lines) Patch
M chrome/browser/notifications/balloon_host.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_contents.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/tab_contents/interstitial_page.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/tab_contents/interstitial_page.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/tab_contents/tab_contents.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M content/common/view_messages.h View 2 chunks +5 lines, -4 lines 0 comments Download
M content/renderer/render_view.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_view.cc View 3 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Evan Martin
cbentzel@chromium.org, johnnyg@chromium.org, avi@chromium.org, jam@chromium.org: you are OWNERS of various pieces of this review
9 years, 8 months ago (2011-04-20 19:41:29 UTC) #1
cbentzel
On 2011/04/20 19:41:29, Evan Martin wrote: > mailto:cbentzel@chromium.org, mailto:johnnyg@chromium.org, mailto:avi@chromium.org, jam@chromium.org: > you are OWNERS ...
9 years, 8 months ago (2011-04-20 20:01:20 UTC) #2
jam
9 years, 8 months ago (2011-04-20 20:17:03 UTC) #3 
content lgtm

Powered by Google App Engine
This is Rietveld 408576698