Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1311)

Unified Diff: content/browser/tab_contents/interstitial_page.cc

Issue 6880073: Plumb direction of document title through IPC layer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/tab_contents/interstitial_page.h ('k') | content/browser/tab_contents/tab_contents.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/tab_contents/interstitial_page.cc
diff --git a/content/browser/tab_contents/interstitial_page.cc b/content/browser/tab_contents/interstitial_page.cc
index da0b9685b5110e67384907a9892f5a43eab902e1..ec074ff643aadbae86887a71b919eb704b8e989f 100644
--- a/content/browser/tab_contents/interstitial_page.cc
+++ b/content/browser/tab_contents/interstitial_page.cc
@@ -385,7 +385,8 @@ void InterstitialPage::DidNavigate(
void InterstitialPage::UpdateTitle(RenderViewHost* render_view_host,
int32 page_id,
- const std::wstring& title) {
+ const string16& title,
+ WebKit::WebTextDirection title_direction) {
DCHECK(render_view_host == render_view_host_);
NavigationEntry* entry = tab_->controller().GetActiveEntry();
if (!entry) {
@@ -407,7 +408,9 @@ void InterstitialPage::UpdateTitle(RenderViewHost* render_view_host,
original_tab_title_ = UTF16ToWideHack(entry->title());
should_revert_tab_title_ = true;
}
- entry->set_title(WideToUTF16Hack(title));
+ // TODO(evan): use directionality of title.
+ // http://code.google.com/p/chromium/issues/detail?id=27094
+ entry->set_title(title);
tab_->NotifyNavigationStateChanged(TabContents::INVALIDATE_TITLE);
}
« no previous file with comments | « content/browser/tab_contents/interstitial_page.h ('k') | content/browser/tab_contents/tab_contents.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698