Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Unified Diff: content/browser/tab_contents/tab_contents.cc

Issue 6880073: Plumb direction of document title through IPC layer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/tab_contents/tab_contents.h ('k') | content/common/view_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/tab_contents/tab_contents.cc
diff --git a/content/browser/tab_contents/tab_contents.cc b/content/browser/tab_contents/tab_contents.cc
index b3ecf53b2e9e5e7d6b7d370da49701d3627ebaa5..8bcc8e43422b8bb908dcfd6b3265ed9935583574 100644
--- a/content/browser/tab_contents/tab_contents.cc
+++ b/content/browser/tab_contents/tab_contents.cc
@@ -1991,7 +1991,9 @@ void TabContents::UpdateState(RenderViewHost* rvh,
}
void TabContents::UpdateTitle(RenderViewHost* rvh,
- int32 page_id, const std::wstring& title) {
+ int32 page_id,
+ const string16& title,
+ WebKit::WebTextDirection title_direction) {
// If we have a title, that's a pretty good indication that we've started
// getting useful data.
SetNotWaitingForResponse();
@@ -1999,7 +2001,9 @@ void TabContents::UpdateTitle(RenderViewHost* rvh,
DCHECK(rvh == render_view_host());
NavigationEntry* entry = controller_.GetEntryWithPageID(rvh->site_instance(),
page_id);
- if (!entry || !UpdateTitleForEntry(entry, title))
+ // TODO(evan): use directionality of title.
+ // http://code.google.com/p/chromium/issues/detail?id=27094
+ if (!entry || !UpdateTitleForEntry(entry, UTF16ToWide(title)))
return;
// Broadcast notifications when the UI should be updated.
« no previous file with comments | « content/browser/tab_contents/tab_contents.h ('k') | content/common/view_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698