Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1230)

Unified Diff: content/browser/tab_contents/navigation_entry.h

Issue 6878089: Add and use a base::i18n::StringWithDirection for carrying titles. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review feedback Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tab_contents/navigation_entry.h
diff --git a/content/browser/tab_contents/navigation_entry.h b/content/browser/tab_contents/navigation_entry.h
index 671cc5bf90660e8be200a5acc198800b8defa7d1..2a25f574a1bb336266142ef093a22020c95e9b88 100644
--- a/content/browser/tab_contents/navigation_entry.h
+++ b/content/browser/tab_contents/navigation_entry.h
@@ -10,6 +10,7 @@
#include "base/basictypes.h"
#include "base/memory/ref_counted.h"
+#include "base/i18n/rtl.h"
#include "chrome/common/security_style.h"
#include "content/common/page_transition_types.h"
#include "content/common/page_type.h"
@@ -269,6 +270,11 @@ class NavigationEntry {
// The caller is responsible for detecting when there is no title and
// displaying the appropriate "Untitled" label if this is being displayed to
// the user.
+ void set_title(const base::i18n::String16WithDirection& title) {
+ set_title(title.string());
+ }
+ // TODO(evan): remove the string16-setter once callers are updated.
+ // http://code.google.com/p/chromium/issues/detail?id=27094
void set_title(const string16& title) {
title_ = title;
cached_display_title_.clear();

Powered by Google App Engine
This is Rietveld 408576698