Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Unified Diff: content/browser/tab_contents/interstitial_page.cc

Issue 6878089: Add and use a base::i18n::StringWithDirection for carrying titles. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review feedback Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tab_contents/interstitial_page.cc
diff --git a/content/browser/tab_contents/interstitial_page.cc b/content/browser/tab_contents/interstitial_page.cc
index ec074ff643aadbae86887a71b919eb704b8e989f..c3d7291e397a830259e65bd6f2a16f9f9e864dd3 100644
--- a/content/browser/tab_contents/interstitial_page.cc
+++ b/content/browser/tab_contents/interstitial_page.cc
@@ -383,10 +383,10 @@ void InterstitialPage::DidNavigate(
tab_->SetIsLoading(false, NULL);
}
-void InterstitialPage::UpdateTitle(RenderViewHost* render_view_host,
- int32 page_id,
- const string16& title,
- WebKit::WebTextDirection title_direction) {
+void InterstitialPage::UpdateTitle(
+ RenderViewHost* render_view_host,
+ int32 page_id,
+ const base::i18n::String16WithDirection& title) {
DCHECK(render_view_host == render_view_host_);
NavigationEntry* entry = tab_->controller().GetActiveEntry();
if (!entry) {
@@ -408,8 +408,6 @@ void InterstitialPage::UpdateTitle(RenderViewHost* render_view_host,
original_tab_title_ = UTF16ToWideHack(entry->title());
should_revert_tab_title_ = true;
}
- // TODO(evan): use directionality of title.
- // http://code.google.com/p/chromium/issues/detail?id=27094
entry->set_title(title);
tab_->NotifyNavigationStateChanged(TabContents::INVALIDATE_TITLE);
}

Powered by Google App Engine
This is Rietveld 408576698