Hide Flash storage settings link.

Hide Flash storage settings link.

BUG=58235
TEST=No link in chrome://settings/clearBrowserData and chrome://settings/contentExceptions#cookies. Unless you have a Flash version older than 10.3, that is. Neat, huh?


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82019

[Bernhard Bauer, 2011-04-15 14:24:48]

Please review.

[Evan Stade, 2011-04-15 19:15:11]

http://codereview.chromium.org/6875001/diff/4001/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/core_options_handler.cc (right):

http://codereview.chromium.org/6875001/diff/4001/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/core_options_handler.cc:101: if (type ==
NotificationType::PREF_CHANGED) {
no curlies for single line if statements

http://codereview.chromium.org/6875001/diff/4001/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/core_options_handler.cc:358:
"OptionsPage.setClearPluginLSODataEnabled", *enabled);
I don't think this is necessary. See Preferences.js. All you need is
Preferences.getInstance().addEventListener

http://codereview.chromium.org/6875001/diff/4001/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/core_options_handler.cc:362: if (*pref_name ==
prefs::kClearPluginLSODataEnabled) {
no curlies

http://codereview.chromium.org/6875001/diff/4001/chrome/browser/ui/webui/sett...
File chrome/browser/ui/webui/settings_browsertest.cc (right):

http://codereview.chromium.org/6875001/diff/4001/chrome/browser/ui/webui/sett...
chrome/browser/ui/webui/settings_browsertest.cc:86:
scoped_ptr<StrictMock<MockCoreOptionsHandler> > mock_core_options_handler_;
why is this change needed?

[Bernhard Bauer, 2011-04-17 13:26:54]

http://codereview.chromium.org/6875001/diff/4001/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/core_options_handler.cc (right):

http://codereview.chromium.org/6875001/diff/4001/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/core_options_handler.cc:101: if (type ==
NotificationType::PREF_CHANGED) {
On 2011/04/15 19:15:11, Evan Stade wrote:
> no curlies for single line if statements

Done.

http://codereview.chromium.org/6875001/diff/4001/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/core_options_handler.cc:358:
"OptionsPage.setClearPluginLSODataEnabled", *enabled);
On 2011/04/15 19:15:11, Evan Stade wrote:
> I don't think this is necessary. See Preferences.js. All you need is
> Preferences.getInstance().addEventListener

|clear_plugin_lso_data_enabled_| is bound to local state, not user preferences
(it's just caching whether a plugin that supports clearing LSO data is
installed).

http://codereview.chromium.org/6875001/diff/4001/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/core_options_handler.cc:362: if (*pref_name ==
prefs::kClearPluginLSODataEnabled) {
On 2011/04/15 19:15:11, Evan Stade wrote:
> no curlies

Done.

http://codereview.chromium.org/6875001/diff/4001/chrome/browser/ui/webui/sett...
File chrome/browser/ui/webui/settings_browsertest.cc (right):

http://codereview.chromium.org/6875001/diff/4001/chrome/browser/ui/webui/sett...
chrome/browser/ui/webui/settings_browsertest.cc:86:
scoped_ptr<StrictMock<MockCoreOptionsHandler> > mock_core_options_handler_;
On 2011/04/15 19:15:11, Evan Stade wrote:
> why is this change needed?

PluginDataRemoverHelper needs to be destructed on the UI thread, but during
destruction of the test class the UI thread message loop is already gone, so
|DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI))| fails.

[Evan Stade, 2011-04-18 17:43:05]

lgtm

http://codereview.chromium.org/6875001/diff/7001/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/core_options_handler.cc (right):

http://codereview.chromium.org/6875001/diff/7001/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/core_options_handler.cc:361: if (*pref_name ==
prefs::kClearPluginLSODataEnabled)
can you comment that this is part of local_state and not a user pref?

http://codereview.chromium.org/6875001/diff/7001/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/core_options_handler.cc:362:
UpdateClearPluginLSOData();
early return

[commit-bot: I haz the power, 2011-04-18 21:59:01]

Try job failure for 6875001-11001 on linux:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux&numb...

[commit-bot: I haz the power, 2011-04-18 23:02:51]

Change committed as 82019