Hide Flash storage settings link.

chrome/browser/ui/webui/options/core_options_handler.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/core_options_handler.h"
 
 #include "base/json/json_reader.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/string16.h"
 #include "base/string_number_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
+#include "chrome/browser/browser_process.h"
 #include "chrome/browser/google/google_util.h"
 #include "chrome/browser/metrics/user_metrics.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "content/common/notification_details.h"
 #include "content/common/notification_type.h"
 #include "googleurl/src/gurl.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "grit/locale_settings.h"
 #include "grit/theme_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 
 CoreOptionsHandler::CoreOptionsHandler()
     : handlers_host_(NULL) {
 }
 
 CoreOptionsHandler::~CoreOptionsHandler() {}
 
+void CoreOptionsHandler::Initialize() {
+  clear_plugin_lso_data_enabled_.Init(prefs::kClearPluginLSODataEnabled,
+                                      g_browser_process->local_state(),
+                                      this);
+  UpdateClearPluginLSOData();
+}
+
 void CoreOptionsHandler::GetLocalizedValues(
     DictionaryValue* localized_strings) {
   DCHECK(localized_strings);
   // Main
   localized_strings->SetString("title",
       l10n_util::GetStringUTF16(IDS_SETTINGS_TITLE));
 
   // Managed prefs
   localized_strings->SetString("managedPrefsBannerText",
       l10n_util::GetStringUTF16(IDS_OPTIONS_MANAGED_PREFS));
@@ skipping 39 matching lines @@
 WebUIMessageHandler* CoreOptionsHandler::Attach(WebUI* web_ui) {
   WebUIMessageHandler* result = WebUIMessageHandler::Attach(web_ui);
   DCHECK(web_ui_);
   registrar_.Init(web_ui_->GetProfile()->GetPrefs());
   return result;
 }
 
 void CoreOptionsHandler::Observe(NotificationType type,
                                  const NotificationSource& source,
                                  const NotificationDetails& details) {
-  if (type == NotificationType::PREF_CHANGED)
+  if (type == NotificationType::PREF_CHANGED) {

[Evan Stade, 2011/04/15 19:15:11]

no curlies for single line if statements

[Bernhard Bauer, 2011/04/17 13:26:54]

Done.

     NotifyPrefChanged(Details<std::string>(details).ptr());
+  }
 }
 
 void CoreOptionsHandler::RegisterMessages() {
   web_ui_->RegisterMessageCallback("coreOptionsInitialize",
       NewCallback(this, &CoreOptionsHandler::HandleInitialize));
   web_ui_->RegisterMessageCallback("fetchPrefs",
       NewCallback(this, &CoreOptionsHandler::HandleFetchPrefs));
   web_ui_->RegisterMessageCallback("observePrefs",
       NewCallback(this, &CoreOptionsHandler::HandleObservePrefs));
   web_ui_->RegisterMessageCallback("setBooleanPref",
@@ skipping 230 matching lines @@
 
   ClearPref(pref_name, metric);
 }
 
 void CoreOptionsHandler::HandleUserMetricsAction(const ListValue* args) {
   std::string metric = UTF16ToUTF8(ExtractStringValue(args));
   if (!metric.empty())
     UserMetricsRecordAction(UserMetricsAction(metric.c_str()));
 }
 
+void CoreOptionsHandler::UpdateClearPluginLSOData() {
+  scoped_ptr<Value> enabled(
+      Value::CreateBooleanValue(clear_plugin_lso_data_enabled_.GetValue()));
+  web_ui_->CallJavascriptFunction(
+      "OptionsPage.setClearPluginLSODataEnabled", *enabled);

[Evan Stade, 2011/04/15 19:15:11]

I don't think this is necessary. See Preferences.js. All you need is
Preferences.getInstance().addEventListener

[Bernhard Bauer, 2011/04/17 13:26:54]

|clear_plugin_lso_data_enabled_| is bound to local state, not user preferences
(it's just caching whether a plugin that supports clearing LSO data is
installed).

+}
+
 void CoreOptionsHandler::NotifyPrefChanged(const std::string* pref_name) {
+  if (*pref_name == prefs::kClearPluginLSODataEnabled) {

[Evan Stade, 2011/04/15 19:15:11]

no curlies

[Bernhard Bauer, 2011/04/17 13:26:54]

Done.

+    UpdateClearPluginLSOData();
+  }
+
   PrefService* pref_service = web_ui_->GetProfile()->GetPrefs();
   const PrefService::Preference* pref =
       pref_service->FindPreference(pref_name->c_str());
   if (pref) {
     for (PreferenceCallbackMap::const_iterator iter =
         pref_callback_map_.find(*pref_name);
         iter != pref_callback_map_.end(); ++iter) {
       const std::wstring& callback_function = iter->second;
       ListValue result_value;
       result_value.Append(Value::CreateStringValue(pref_name->c_str()));
 
       DictionaryValue* dict = new DictionaryValue;
       dict->Set("value", pref->GetValue()->DeepCopy());
       dict->SetBoolean("managed", pref->IsManaged());
       result_value.Append(dict);
 
       web_ui_->CallJavascriptFunction(WideToASCII(callback_function),
                                       result_value);
     }
   }
 }