Hide Flash storage settings link.

chrome/browser/ui/webui/settings_browsertest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/core_options_handler.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/ui_test_utils.h"
 #include "content/browser/webui/web_ui_browsertest.h"
 #include "googleurl/src/gurl.h"
 #include "testing/gmock/include/gmock/gmock.h"
@@ skipping 53 matching lines @@
   }
 };
 
 class SettingsWebUITest : public WebUIBrowserTest {
  protected:
   virtual void SetUpInProcessBrowserTestFixture() {
     WebUIBrowserTest::SetUpInProcessBrowserTestFixture();
     AddLibrary(FILE_PATH_LITERAL("settings.js"));
   }
 
-  virtual WebUIMessageHandler* GetMockMessageHandler() {
-    return &mock_core_options_handler_;
+  virtual void SetUpOnMainThread() {
+    mock_core_options_handler_.reset(new StrictMock<MockCoreOptionsHandler>());
   }
 
-  StrictMock<MockCoreOptionsHandler> mock_core_options_handler_;
+  virtual void CleanUpOnMainThread() {
+    mock_core_options_handler_.reset();
+  }
+
+  virtual WebUIMessageHandler* GetMockMessageHandler() {
+    return mock_core_options_handler_.get();
+  }
+
+  scoped_ptr<StrictMock<MockCoreOptionsHandler> > mock_core_options_handler_;

[Evan Stade, 2011/04/15 19:15:11]

why is this change needed?

[Bernhard Bauer, 2011/04/17 13:26:54]

PluginDataRemoverHelper needs to be destructed on the UI thread, but during
destruction of the test class the UI thread message loop is already gone, so
|DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI))| fails.

 };
 
 // Test the end to end js to WebUI handler code path for
 // the message setBooleanPref.
 // TODO(dtseng): add more EXPECT_CALL's when updating js test.
 
 // Crashes on Mac only. See http://crbug.com/79181
 #if defined(OS_MACOSX)
 #define MAYBE_TestSetBooleanPrefTriggers DISABLED_TestSetBooleanPrefTriggers
 #else
 #define MAYBE_TestSetBooleanPrefTriggers TestSetBooleanPrefTriggers
 #endif
 IN_PROC_BROWSER_TEST_F(SettingsWebUITest, MAYBE_TestSetBooleanPrefTriggers) {
   // This serves as an example of a very constrained test.
   ListValue true_list_value;
   true_list_value.Append(Value::CreateStringValue("browser.show_home_button"));
   true_list_value.Append(Value::CreateBooleanValue(true));
   true_list_value.Append(
       Value::CreateStringValue("Options_Homepage_HomeButton"));
   ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUISettingsURL));
-  EXPECT_CALL(mock_core_options_handler_,
+  EXPECT_CALL(*mock_core_options_handler_,
       HandleSetBooleanPref(Eq_ListValue(&true_list_value)));
   ASSERT_TRUE(RunJavascriptTest("testSetBooleanPrefTriggers"));
 }