Usability improvements to about:gpu status

Usability improvements to about:gpu status

The previous implementation of status was tied to the features that the blacklist understood. This limited our expressiveness about the status of user-facing features. For example....
  Before:
  - Accelerated compositing: enabled/disabled/unavailable

  After:
  - 3D CSS: enabled, unavailable, disabled
  - Compositing: software, software rendering due to gpu unavailable, softawre rendering due to being disabled, enabled

Key here is decoupling the features reported in the status from gpu blacklist features enum. On top of that, the states are expanded to show difference between off, off and falling back to software, and software rendering because it wasn't enabled.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81957

[Avi (use Gerrit), 2011-04-15 13:55:14]

content/browser LGTM

[zmo, 2011-04-15 17:06:35]

LGTM (some nits, please fix before commit)

http://codereview.chromium.org/6870004/diff/1/content/browser/gpu_blacklist.cc
File content/browser/gpu_blacklist.cc (right):

http://codereview.chromium.org/6870004/diff/1/content/browser/gpu_blacklist.c...
content/browser/gpu_blacklist.cc:717: }
Please move this into the anonymous namespace at the top of this file.

http://codereview.chromium.org/6870004/diff/1/content/browser/gpu_blacklist.c...
content/browser/gpu_blacklist.cc:802:
feature_status_list->Append(NewStatusValue("multisampling",
remove two extra white space

http://codereview.chromium.org/6870004/diff/1/content/browser/gpu_blacklist.h
File content/browser/gpu_blacklist.h (right):

http://codereview.chromium.org/6870004/diff/1/content/browser/gpu_blacklist.h...
content/browser/gpu_blacklist.h:96: bool
IsFeatureBlacklisted(GpuFeatureFlags::GpuFeatureType feature) const;
Please make this function private.  The only public interface to decide if a
feature is supported is DeterminGpuFeatureFlags().  Without calling Determin...,
calling this function will return invalid information, thus, we should not allow
calling this function from outside GpuBlacklist class.

[arv (Not doing code reviews), 2011-04-15 22:53:04]

HTML/JS/CSS LGTM