Usability improvements to about:gpu status

content/browser/gpu_blacklist.h

Index: content/browser/gpu_blacklist.h
diff --git a/content/browser/gpu_blacklist.h b/content/browser/gpu_blacklist.h
index c2f85368b12e71e92ad5b14c0340ed02833395f1..aad31f1f54616f37cac5b2e73f58d27663b3c51f 100644
--- a/content/browser/gpu_blacklist.h
+++ b/content/browser/gpu_blacklist.h
@@ -70,9 +70,17 @@ class GpuBlacklist {
   // Each entry in feature_status has:
   // {
   //    name:  "name of feature"
-  //    status: "enabled" | "unavailable" | "software" | "disabled";
+  //    status: "enabled" | "unavailable_software" | "unavailable_off" |
+  //            "software" | "disabled_off" | "disabled_softare";
   // }
   //
+  // The features reported are not 1:1 with GpuFeatureType. Rather, they are:
+  //    '2d_canvas'
+  //    '3d_css'
+  //    'composting',
+  //    'webgl',
+  //    'multisampling'
+  //
   // Each problems has:
   // {
   //    "description": "Your GPU is too old",
@@ -85,6 +93,8 @@ class GpuBlacklist {
                           bool disable_experimental_webgl,
                           bool disable_multisampling) const;
 
+  bool IsFeatureBlacklisted(GpuFeatureFlags::GpuFeatureType feature) const;

[zmo, 2011/04/15 17:06:35]

Please make this function private.  The only public interface to decide if a
feature is supported is DeterminGpuFeatureFlags().  Without calling Determin...,
calling this function will return invalid information, thus, we should not allow
calling this function from outside GpuBlacklist class.

+
   // Return the largest entry id.  This is used for histogramming.
   uint32 max_entry_id() const;