Usability improvements to about:gpu status

content/browser/gpu_blacklist.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_GPU_BLACKLIST_H_
 #define CONTENT_BROWSER_GPU_BLACKLIST_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 52 matching lines @@
 
   // Returns status information on the blacklist. This is two parted:
   // {
   //    featureStatus: []
   //    problems: []
   // }
   //
   // Each entry in feature_status has:
   // {
   //    name:  "name of feature"
-  //    status: "enabled" | "unavailable" | "software" | "disabled";
+  //    status: "enabled" | "unavailable_software" | "unavailable_off" |
+  //            "software" | "disabled_off" | "disabled_softare";
   // }
   //
+  // The features reported are not 1:1 with GpuFeatureType. Rather, they are:
+  //    '2d_canvas'
+  //    '3d_css'
+  //    'composting',
+  //    'webgl',
+  //    'multisampling'
+  //
   // Each problems has:
   // {
   //    "description": "Your GPU is too old",
   //    "crBugs": [1234],
   //    "webkitBugs": []
   // }
   Value* GetFeatureStatus(bool gpu_access_allowed,
                           bool disable_accelerated_compositing,
                           bool enable_accelerated_2D_canvas,
                           bool disable_experimental_webgl,
                           bool disable_multisampling) const;
 
+  bool IsFeatureBlacklisted(GpuFeatureFlags::GpuFeatureType feature) const;

[zmo, 2011/04/15 17:06:35]

Please make this function private.  The only public interface to decide if a
feature is supported is DeterminGpuFeatureFlags().  Without calling Determin...,
calling this function will return invalid information, thus, we should not allow
calling this function from outside GpuBlacklist class.

+
   // Return the largest entry id.  This is used for histogramming.
   uint32 max_entry_id() const;
 
   // Collects the version of the current blacklist.  Returns false and sets
   // major and minor to 0 on failure.
   bool GetVersion(uint16* major, uint16* monir) const;
 
   // Collects the version of the current blacklist from a parsed json file.
   // Returns false and sets major and minor to 0 on failure.
   static bool GetVersion(
@@ skipping 187 matching lines @@
   // user machine.  It is updated everytime DetermineGpuFeatureFlags() is
   // called and is used later by GetGpuFeatureFlagEntries().
   std::vector<GpuBlacklistEntry*> active_entries_;
 
   uint32 max_entry_id_;
 
   DISALLOW_COPY_AND_ASSIGN(GpuBlacklist);
 };
 
 #endif  // CONTENT_BROWSER_GPU_BLACKLIST_H_