Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2552)

Unified Diff: chrome/browser/sync/glue/extension_sync_traits.cc

Issue 6852029: [Sync] Move some extension-sync-related logic to ExtensionService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add TODO, fix lint Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/extension_sync_traits.cc
diff --git a/chrome/browser/sync/glue/extension_sync_traits.cc b/chrome/browser/sync/glue/extension_sync_traits.cc
index f45dabbf3496db017b6ac086fd8b013c2021cae3..d425f91845ce7c0986e722dada5776fb3d06c0d8 100644
--- a/chrome/browser/sync/glue/extension_sync_traits.cc
+++ b/chrome/browser/sync/glue/extension_sync_traits.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -57,24 +57,6 @@ bool GetExtensionSpecificsFromEntity(
return true;
}
-bool IsSyncableExtension(Extension::Type type, const GURL& update_url) {
- switch (type) {
- case Extension::TYPE_EXTENSION:
- return true;
- case Extension::TYPE_USER_SCRIPT:
- // We only want to sync user scripts with update URLs.
- return !update_url.is_empty();
- default:
- return false;
- }
-}
-
-bool IsValidAndSyncableExtension(const Extension& extension) {
- return
- IsExtensionValid(extension) &&
- IsSyncableExtension(extension.GetType(), extension.update_url());
-}
-
bool IsExtensionUninstall(
const UninstalledExtensionInfo& uninstalled_extension_info) {
return IsSyncableExtension(uninstalled_extension_info.extension_type,
@@ -120,17 +102,6 @@ bool GetExtensionSpecificsFromEntityOfApp(
return true;
}
-bool IsSyncableApp(Extension::Type type) {
- return
- (type == Extension::TYPE_HOSTED_APP) ||
- (type == Extension::TYPE_PACKAGED_APP);
-}
-
-bool IsValidAndSyncableApp(
- const Extension& extension) {
- return IsExtensionValid(extension) && IsSyncableApp(extension.GetType());
-}
-
bool IsAppUninstall(
const UninstalledExtensionInfo& uninstalled_extension_info) {
return IsSyncableApp(uninstalled_extension_info.extension_type);

Powered by Google App Engine
This is Rietveld 408576698