[Sync] Move some extension-sync-related logic to ExtensionService

chrome/browser/extensions/extension_sync_data.h

Index: chrome/browser/extensions/extension_sync_data.h
diff --git a/chrome/browser/extensions/extension_sync_data.h b/chrome/browser/extensions/extension_sync_data.h
new file mode 100644
index 0000000000000000000000000000000000000000..9c5480d9780d1c0d81c2da3b7ae43ab8af8214e0
--- /dev/null
+++ b/chrome/browser/extensions/extension_sync_data.h
@@ -0,0 +1,31 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SYNC_DATA_H_
+#define CHROME_BROWSER_EXTENSIONS_EXTENSION_SYNC_DATA_H_
+#pragma once
+
+#include <string>
+
+#include "base/version.h"
+#include "googleurl/src/gurl.h"
+
+struct ExtensionSyncData {

[asargent_no_longer_on_chrome, 2011/04/14 23:32:14]

nit: Even though this is just a struct, it would be helpful if you had a brief
overview comment here ala
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Class_Comments

[akalin, 2011/04/15 01:17:11]

Done.

+  ExtensionSyncData();
+  ~ExtensionSyncData();
+
+  std::string id;
+
+  // Version-independent properties.
+  bool uninstalled;
+  bool enabled;
+  bool incognito_enabled;
+
+  Version version;
+
+  // Version-dependent properties.

[asargent_no_longer_on_chrome, 2011/04/14 23:32:14]

Isn't "version" version-dependent? :)

Actually I'm a little confused by what you mean by version-dependent and
version-independent. Do you mean that the update url could change between 2
versions of an extension, but it's not possible that sync would also notice a
change in the enabled or incognito setting in the same sync "transaction"? 

[akalin, 2011/04/15 01:17:11]

Added clarifying comments.

+  GURL update_url;
+};
+
+#endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_SYNC_DATA_H_