[Sync] Move some extension-sync-related logic to ExtensionService

chrome/browser/sync/glue/extension_sync_traits.cc

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/glue/extension_sync_traits.h"
 
 #include "base/string_piece.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/sync/engine/syncapi.h"
 #include "chrome/browser/sync/glue/extension_util.h"
 #include "chrome/browser/sync/protocol/app_specifics.pb.h"
@@ skipping 38 matching lines @@
 bool GetExtensionSpecificsFromEntity(
     const sync_pb::EntitySpecifics& entity_specifics,
     sync_pb::ExtensionSpecifics* extension_specifics) {
   if (!entity_specifics.HasExtension(sync_pb::extension)) {
     return false;
   }
   *extension_specifics = entity_specifics.GetExtension(sync_pb::extension);
   return true;
 }
 
-bool IsSyncableExtension(Extension::Type type, const GURL& update_url) {
-  switch (type) {
-    case Extension::TYPE_EXTENSION:
-      return true;
-    case Extension::TYPE_USER_SCRIPT:
-      // We only want to sync user scripts with update URLs.
-      return !update_url.is_empty();
-    default:
-      return false;
-  }
-}
-
-bool IsValidAndSyncableExtension(const Extension& extension) {
-  return
-      IsExtensionValid(extension) &&
-      IsSyncableExtension(extension.GetType(), extension.update_url());
-}
-
 bool IsExtensionUninstall(
     const UninstalledExtensionInfo& uninstalled_extension_info) {
   return IsSyncableExtension(uninstalled_extension_info.extension_type,
                              uninstalled_extension_info.update_url);
 }
 
 }  // namespace
 
 ExtensionSyncTraits GetExtensionSyncTraits() {
   return ExtensionSyncTraits(syncable::EXTENSIONS,
@@ skipping 25 matching lines @@
     const sync_pb::EntitySpecifics& entity_specifics,
     sync_pb::ExtensionSpecifics* extension_specifics) {
   if (!entity_specifics.HasExtension(sync_pb::app)) {
     return false;
   }
   *extension_specifics =
       entity_specifics.GetExtension(sync_pb::app).extension();
   return true;
 }
 
-bool IsSyncableApp(Extension::Type type) {
-  return
-      (type == Extension::TYPE_HOSTED_APP) ||
-      (type == Extension::TYPE_PACKAGED_APP);
-}
-
-bool IsValidAndSyncableApp(
-    const Extension& extension) {
-  return IsExtensionValid(extension) && IsSyncableApp(extension.GetType());
-}
-
 bool IsAppUninstall(
     const UninstalledExtensionInfo& uninstalled_extension_info) {
   return IsSyncableApp(uninstalled_extension_info.extension_type);
 }
 
 }  // namespace
 
 ExtensionSyncTraits GetAppSyncTraits() {
   return ExtensionSyncTraits(syncable::APPS,
                              &IsValidAndSyncableApp,
                              &IsAppUninstall,
                              "google_chrome_apps",
                              &GetExtensionSpecificsOfApp,
                              &SetExtensionSpecificsOfApp,
                              &GetExtensionSpecificsFromEntityOfApp);
 }
 
 }  // namespace browser_sync